Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sonar #286

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Fix sonar #286

merged 5 commits into from
Jan 8, 2025

Conversation

figueroa1395
Copy link
Contributor

@figueroa1395 figueroa1395 commented Jan 7, 2025 •
edited
Loading

Sonar is complaining about several things, this PR attempts to fix them:

@figueroa1395
ignore false positive
da5a9d9 
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
@figueroa1395
bumped to sonarqube
f67f33a 
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
@figueroa1395
format
96692c0 
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
@figueroa1395 figueroa1395 self-assigned this Jan 7, 2025
@figueroa1395 figueroa1395 added the bug Something isn't working label Jan 7, 2025
@figueroa1395 figueroa1395 requested a review from mgovers January 7, 2025 15:27
mgovers
mgovers previously approved these changes Jan 8, 2025
View reviewed changes
@mgovers mgovers dismissed their stale review January 8, 2025 06:59

new review comment found

@figueroa1395
address comment
e9911cc 
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
@figueroa1395
fixed #NOSONAR
faa51a6 
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@figueroa1395 figueroa1395 enabled auto-merge January 8, 2025 09:16
@figueroa1395 figueroa1395 added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit 906969e Jan 8, 2025
26 checks passed
@figueroa1395 figueroa1395 deleted the fix-sonar branch January 8, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgovers mgovers mgovers approved these changes

Assignees

@figueroa1395 figueroa1395

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@figueroa1395 @mgovers