-
Notifications
You must be signed in to change notification settings - Fork 33
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
- Loading branch information
1 parent
ef9e1a6
commit c146e66
Showing
1 changed file
with
4 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,19 +45,19 @@ TEST_CASE("Serialization") { | |
source.data()); | ||
CHECK(PGM_error_code(hl) == PGM_no_error); | ||
|
||
SUBCASE("json") { | ||
SUBCASE("JSON") { | ||
SerializerPtr const json_serializer{ | ||
PGM_create_serializer(hl, dataset, static_cast<PGM_Idx>(SerializationFormat::json))}; | ||
auto* const serializer = json_serializer.get(); | ||
CHECK(PGM_error_code(hl) == PGM_no_error); | ||
|
||
SUBCASE("to zero-terminated string") { | ||
SUBCASE("To zero-terminated string") { | ||
std::string json_result = PGM_serializer_get_to_zero_terminated_string(hl, serializer, 0, -1); | ||
CHECK(PGM_error_code(hl) == PGM_no_error); | ||
CHECK(json_result == json_data); | ||
} | ||
|
||
SUBCASE("to binary buffer") { | ||
SUBCASE("To binary buffer") { | ||
char const* buffer_data{}; | ||
Idx buffer_size{}; | ||
PGM_serializer_get_to_binary_buffer(hl, serializer, 0, &buffer_data, &buffer_size); | ||
|
@@ -67,7 +67,7 @@ TEST_CASE("Serialization") { | |
} | ||
} | ||
|
||
SUBCASE("msgpack") { | ||
SUBCASE("MessagePack") { | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
mgovers
Member
|
||
SerializerPtr const msgpack_serializer{ | ||
PGM_create_serializer(hl, dataset, static_cast<PGM_Idx>(SerializationFormat::msgpack))}; | ||
auto* const serializer = msgpack_serializer.get(); | ||
|
msgpack (lowercase) is the formal name. I don't mind the change but just so you know