Skip to content

Commit

Permalink
resolve comments
Browse files Browse the repository at this point in the history
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
  • Loading branch information
Jerry-Jinfeng-Guo committed Jun 7, 2024
1 parent ef9e1a6 commit c146e66
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tests/c_api_tests/test_serialization.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -45,19 +45,19 @@ TEST_CASE("Serialization") {
source.data());
CHECK(PGM_error_code(hl) == PGM_no_error);

SUBCASE("json") {
SUBCASE("JSON") {
SerializerPtr const json_serializer{
PGM_create_serializer(hl, dataset, static_cast<PGM_Idx>(SerializationFormat::json))};
auto* const serializer = json_serializer.get();
CHECK(PGM_error_code(hl) == PGM_no_error);

SUBCASE("to zero-terminated string") {
SUBCASE("To zero-terminated string") {
std::string json_result = PGM_serializer_get_to_zero_terminated_string(hl, serializer, 0, -1);
CHECK(PGM_error_code(hl) == PGM_no_error);
CHECK(json_result == json_data);
}

SUBCASE("to binary buffer") {
SUBCASE("To binary buffer") {
char const* buffer_data{};
Idx buffer_size{};
PGM_serializer_get_to_binary_buffer(hl, serializer, 0, &buffer_data, &buffer_size);
Expand All @@ -67,7 +67,7 @@ TEST_CASE("Serialization") {
}
}

SUBCASE("msgpack") {
SUBCASE("MessagePack") {

This comment has been minimized.

Copy link
@mgovers

mgovers Jun 7, 2024

Member

msgpack (lowercase) is the formal name. I don't mind the change but just so you know

This comment has been minimized.

Copy link
@Jerry-Jinfeng-Guo

Jerry-Jinfeng-Guo Jun 7, 2024

Author Contributor

image

This comment has been minimized.

Copy link
@mgovers

mgovers Jun 7, 2024

Member

That's the org, right? Like power-grid-model is the library but PowerGridModel is the org. edit, you're right, it's the other way around

SerializerPtr const msgpack_serializer{
PGM_create_serializer(hl, dataset, static_cast<PGM_Idx>(SerializationFormat::msgpack))};
auto* const serializer = msgpack_serializer.get();
Expand Down

0 comments on commit c146e66

Please sign in to comment.