Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Automatic tap changer documentation #606

Merged
merged 31 commits into from
Jun 3, 2024
Merged

[Feature] Automatic tap changer documentation #606

merged 31 commits into from
Jun 3, 2024

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented May 22, 2024 •
edited
Loading

No description provided.

@mgovers
first setup for auto tap docs
4dd2091 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers added the documentation Improvements or additions to documentation label May 22, 2024
mgovers and others added 11 commits May 23, 2024 08:26
@mgovers
fix typos
be40cb1 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
fix typos
6d727e1 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
explain documentation
e917fe0 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
fix typo
569ab3f 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Merge branch 'main' into feature/auto-tap-docs
a2fc831
@mgovers
Merge remote-tracking branch 'origin/main' into feature/auto-tap-docs
e6c330d 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
minor typo
4f7584f 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Merge remote-tracking branch 'origin/main' into feature/auto-tap-docs
36b5205 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
better equations
d8faf43 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
add calculation docs on auto tap
d0e010a 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
cleanup
c383e2c 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers marked this pull request as ready for review May 27, 2024 07:40
mgovers and others added 3 commits May 27, 2024 11:08
@mgovers
fix typesetting
a008126 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
add tap changing strategy to default imports
e8fb8a5 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Merge branch 'main' into feature/auto-tap-docs
de09944
@mgovers
more elaboration on the u_band
5c8c22a 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@petersalemink95
Copy link
Member

Looks good! Left some comments. Didn't check the equations for Uband and line drop compensation (yet)

@mgovers
resolve some comments
4a2a853 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Copy link
Member Author

mgovers commented May 29, 2024 •
edited
Loading

resolved the comments that i was able to resolve. can you please provide input to the others?

@mgovers
remove calculated bounds on min uband and line drop compensation
7c0e136 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
nitbharambe
nitbharambe previously approved these changes May 30, 2024
View reviewed changes
@mgovers
fix layout
4721121 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers added 2 commits May 31, 2024 08:22
@mgovers
fix layout
0f70f38 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
slightly elaborate any strategy
d01c83b 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Jerry-Jinfeng-Guo
Jerry-Jinfeng-Guo reviewed May 31, 2024
View reviewed changes
docs/user_manual/calculations.md Outdated Show resolved Hide resolved
docs/user_manual/calculations.md Outdated Show resolved Hide resolved
docs/user_manual/calculations.md Outdated Show resolved Hide resolved
docs/user_manual/calculations.md Outdated Show resolved Hide resolved
docs/user_manual/calculations.md Outdated Show resolved Hide resolved
mgovers and others added 5 commits May 31, 2024 11:21
@mgovers
resolve comments
2e22b86 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Merge branch 'main' into feature/auto-tap-docs
4acaabb
@mgovers
Merge branch 'feature/auto-tap-docs' of https://github.com/PowerGridM…
4c3edcb 
…odel/power-grid-model into feature/auto-tap-docs
@mgovers
another attempt
463c453 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
improve
e6b8e2b 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
more comments
106cf5d 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers and others added 2 commits May 31, 2024 11:47
@mgovers
improve more
a9019ad 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Merge branch 'main' into feature/auto-tap-docs
3b62d97
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

nitbharambe
nitbharambe approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@nitbharambe nitbharambe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merge post other comment resolves.

@nitbharambe nitbharambe enabled auto-merge June 3, 2024 07:25
@nitbharambe nitbharambe disabled auto-merge June 3, 2024 07:25
@TonyXiang8787
Copy link
Member

@nitbharambe can we go ahead and merge this one?

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit 47ee9e5 Jun 3, 2024
26 checks passed
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo deleted the feature/auto-tap-docs branch June 3, 2024 09:19
@mgovers mgovers mentioned this pull request Jun 3, 2024
Merged
@mgovers mgovers mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersalemink95 petersalemink95 petersalemink95 left review comments

@nitbharambe nitbharambe nitbharambe approved these changes

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mgovers @petersalemink95 @TonyXiang8787 @Jerry-Jinfeng-Guo @nitbharambe