Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/tap regulator output #607

Merged
merged 9 commits into from
May 24, 2024
Merged

Feature/tap regulator output #607

merged 9 commits into from
May 24, 2024

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented May 23, 2024 •
edited
Loading

output tap positions for the regulators with the original implementation of #598

mgovers added 2 commits May 23, 2024 16:06
@mgovers
output transformer tap regulator
9294395 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
output tap position
8f6104c 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers added the do-not-merge This should not be merged label May 23, 2024
mgovers added 2 commits May 23, 2024 17:06
@mgovers
pos is an ID???
8fd28fc 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
remove constexpr
34f59b3 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers mentioned this pull request May 23, 2024
Merged
@mgovers
fix clang
05e3d27 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Copy link
Member Author

mgovers commented May 23, 2024

@nitish let's discuss tomorrow whether to merge this into #598 and/or also to main. that would mean we reach the sprint goal and cleanup (making it efficient) would then be a follow-up

@mgovers
only output regulated tap positions
c224f12 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers changed the title Feature/tap regulator output [DO NOT MERGE] Feature/tap regulator output May 24, 2024
@mgovers mgovers added improvement Improvement on internal implementation feature New feature or request and removed do-not-merge This should not be merged improvement Improvement on internal implementation labels May 24, 2024
@mgovers mgovers marked this pull request as ready for review May 24, 2024 06:49
mgovers added 2 commits May 24, 2024 08:58
@mgovers
remove deprecated test
6d448b0 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
check for optimal output of auto tap pos
39e4501 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
resolve comments
4fd52b6 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo merged commit b83b87a into feature/update-main-model-for-tap-changer May 24, 2024
24 checks passed
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo deleted the feature/tap-regulator-output-1 branch May 24, 2024 08:12
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
37.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@mgovers mgovers mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo approved these changes

@nitbharambe nitbharambe Awaiting requested review from nitbharambe

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgovers @Jerry-Jinfeng-Guo