Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconfigure cmake preset #622

Merged
merged 10 commits into from
Jun 6, 2024
Merged

Reconfigure cmake preset #622

merged 10 commits into from
Jun 6, 2024

Conversation

TonyXiang8787
Copy link
Member

Let Cmake presets to choose the compiler gcc and clang automatically.

@TonyXiang8787
dev build
2606970 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
use gcc variable
6a9564f 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
clang base
91a83c1 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
modify ci
965b2e5 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
docs
3cc3f13 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787 TonyXiang8787 requested a review from mgovers June 4, 2024 12:05
@TonyXiang8787
clang tidy
17d07fb 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
mgovers
mgovers reviewed Jun 4, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakePresets.json Outdated Show resolved Hide resolved
@TonyXiang8787
comments
1c6cd11 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787 TonyXiang8787 requested a review from mgovers June 4, 2024 12:29
mgovers
mgovers previously approved these changes Jun 4, 2024
View reviewed changes
@mgovers mgovers enabled auto-merge June 4, 2024 12:32
Jerry-Jinfeng-Guo
Jerry-Jinfeng-Guo reviewed Jun 4, 2024
View reviewed changes
Copy link
Contributor

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is still one check away from merge

docs/advanced_documentation/build-guide.md Outdated Show resolved Hide resolved
docs/advanced_documentation/build-guide.md Outdated Show resolved Hide resolved
@mgovers
Copy link
Member

mgovers commented Jun 4, 2024

gcc build fails

@TonyXiang8787
Copy link
Member Author

@mgovers can you have a look at the package test error?

@mgovers
fix package tests
efbbe30 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@TonyXiang8787 TonyXiang8787 disabled auto-merge June 5, 2024 13:23
mgovers and others added 2 commits June 5, 2024 22:50
@mgovers
Merge branch 'main' into feature/cmake-configure
c5b14bd
@mgovers
resolve comments
b08080c 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers enabled auto-merge June 6, 2024 08:06
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mgovers mgovers added this pull request to the merge queue Jun 6, 2024
Merged via the queue into main with commit 75db84c Jun 6, 2024
25 checks passed
@mgovers mgovers deleted the feature/cmake-configure branch June 6, 2024 19:35
@mgovers mgovers mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo left review comments

@mgovers mgovers mgovers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TonyXiang8787 @mgovers @Jerry-Jinfeng-Guo