Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Numerically stable source injection in power flow. #666

Merged
merged 34 commits into from
Jul 23, 2024
Merged

[FEATURE] Numerically stable source injection in power flow. #666

merged 34 commits into from
Jul 23, 2024

Conversation

figueroa1395
Copy link
Contributor

Closes #458

@figueroa1395
Numerically stable source injection.
f97cd58 
Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
@figueroa1395
Format
d532993 
Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
Jerry-Jinfeng-Guo
Jerry-Jinfeng-Guo reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's still in draft, but I just could not un-see it :)

...id_model_c/power_grid_model/include/power_grid_model/math_solver/common_solver_functions.hpp Outdated Show resolved Hide resolved
@figueroa1395
Optimized
3e90c83 
Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
@figueroa1395
Corrected formulas
762cd1c 
Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
@figueroa1395
Formatted
875bc74 
Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
@figueroa1395
Formatted
d9b7e6d 
Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
@figueroa1395
Fixed out_of_range error.
f275e9c 
Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
@figueroa1395
Formatting
f97fdbb 
Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
@nitbharambe nitbharambe mentioned this pull request Jul 9, 2024
Merged
@figueroa1395
Working for fake-asymmetric C++-tests
3be153a 
Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
@figueroa1395
Correct calculation of Z_ref_total
b8ffeac 
Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
@figueroa1395
Addressed review comments.
9735263 
Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
@figueroa1395
Formatting and naming
ff77f1d 
Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
@figueroa1395
Clang-tidy
a411822 
Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
figueroa1395 and others added 3 commits July 15, 2024 10:06
@figueroa1395
Addressed comments.
2f64ee4 
Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
@figueroa1395
Floating point error
3934c7f 
Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
@mgovers
Merge branch 'main' into feature/numerically_stable_source_injection_…
22bbaa4 
…in_power_flow
@figueroa1395
Cleaning
743e267 
Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
@figueroa1395
Merge branch 'main' of https://github.com/PowerGridModel/power-grid-m…
3eec1b5 
…odel into feature/numerically_stable_source_injection_in_power_flow
@figueroa1395
Merge branch 'feature/numerically_stable_source_injection_in_power_fl…
3acb0bb 
…ow' of https://github.com/PowerGridModel/power-grid-model into feature/numerically_stable_source_injection_in_power_flow
@figueroa1395
Clang-tidy
ad7b082 
Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
Jerry-Jinfeng-Guo
Jerry-Jinfeng-Guo reviewed Jul 22, 2024
View reviewed changes
Copy link
Contributor

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know the full progress of this PR as it has changed in shape a couple times since I last checked. I am only here leaving comments regarding the code itself.

...id_model_c/power_grid_model/include/power_grid_model/math_solver/common_solver_functions.hpp Show resolved Hide resolved
...id_model_c/power_grid_model/include/power_grid_model/math_solver/common_solver_functions.hpp Outdated Show resolved Hide resolved
...id_model_c/power_grid_model/include/power_grid_model/math_solver/common_solver_functions.hpp Outdated Show resolved Hide resolved
TonyXiang8787
TonyXiang8787 previously requested changes Jul 22, 2024
View reviewed changes
Copy link
Member

@TonyXiang8787 TonyXiang8787 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on the mathematics. Some comments on the code review.

@figueroa1395
[skip ci] most review comments addressed. some tests fail
12c77b5 
Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
@figueroa1395
Fixed tests
f55d33b 
Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
@figueroa1395
Fixed code quality
9c87ef7 
Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
@figueroa1395
Tidy
46481d9 
Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
@figueroa1395
Adressed comment
537825f 
Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
@figueroa1395 figueroa1395 dismissed TonyXiang8787’s stale review July 23, 2024 09:30

Review changes already implemented.

@figueroa1395 figueroa1395 enabled auto-merge July 23, 2024 09:49
@nitbharambe
Apply suggestions from code review
7aee81a 
Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@figueroa1395 figueroa1395 added this pull request to the merge queue Jul 23, 2024
Merged via the queue into main with commit e22b528 Jul 23, 2024
26 checks passed
@figueroa1395 figueroa1395 deleted the feature/numerically_stable_source_injection_in_power_flow branch July 23, 2024 11:42
@mgovers mgovers mentioned this pull request Oct 15, 2024
Merged
2 tasks
@mgovers mgovers mentioned this pull request Nov 5, 2024
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersalemink95 petersalemink95 petersalemink95 left review comments

@mgovers mgovers mgovers left review comments

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo left review comments

@nitbharambe nitbharambe nitbharambe approved these changes

@TonyXiang8787 TonyXiang8787 TonyXiang8787 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Use more numerically stable method to calculate source injection in power flow
6 participants
@figueroa1395 @Jerry-Jinfeng-Guo @mgovers @TonyXiang8787 @petersalemink95 @nitbharambe