Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Added missing metaclass #667

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

figueroa1395
Copy link
Contributor

Small fix to provide __contains__ to ComponentType.

Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
@figueroa1395 figueroa1395 marked this pull request as ready for review July 9, 2024 07:36
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your generated code checker is already doing its job 😛

@figueroa1395
Copy link
Contributor Author

@mgovers I totally forgot about it. I will properly fix it then!

Signed-off-by: Santiago Figueroa <santiago.figueroa.manrique@alliander.com>
@mgovers mgovers enabled auto-merge July 9, 2024 08:05
Copy link

sonarqubecloud bot commented Jul 9, 2024

@mgovers mgovers added this pull request to the merge queue Jul 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 9, 2024
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit a6d607b Jul 9, 2024
26 checks passed
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo deleted the feature/metaclass_to_component_type branch July 9, 2024 10:39
@mgovers mgovers mentioned this pull request Nov 5, 2024
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants