Columnar data Python API step 2 #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
nitbharambe
commented
Jul 16, 2024
mgovers
reviewed
Jul 17, 2024
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
This reverts commit 2d5c41f. Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
figueroa1395
previously approved these changes
Jul 22, 2024
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
figueroa1395
previously approved these changes
Jul 22, 2024
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Jerry-Jinfeng-Guo
requested changes
Jul 22, 2024
There was a problem hiding this comment.
I think for now the temporary type hint of dict[ComponentType, np.ndarray] | dict[ComponentType, dict[str, np.ndarray]] is ok. We can make subsequent changes when merging the other PR where data types are touched. Only request a minor change in the docstring. i.e., "memory overhead" -> "memory footprint"
|
@Jerry-Jinfeng-Guo I believe you are referring to #465. I will leave it here for reference. |
#663, but yes |
This reverts commit ba7ce89. Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
nitbharambe
commented
Jul 22, 2024
Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
|
Jerry-Jinfeng-Guo
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change behavior of output_component type to the decided logic.