Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add nightly #736

Merged
merged 17 commits into from
Sep 26, 2024
Merged

Feature/add nightly #736

merged 17 commits into from
Sep 26, 2024

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Sep 25, 2024

  • Adds support for nightly build
  • Disables benchmark from the all target

Closes #735

@mgovers
exclude benchmark from all, add to clang-tidy workflow
25bd94a 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
add nightly
3f806ec 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
re-attempt enable nightly
74a60f4 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
attempt resolve deadlock
d019115 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
remove deadlock
6a8f3f7 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
just skip deadlock altogether
e863627 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
resolve some TODOs
1f35c87 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
fix target option
f4f61ea 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
fix
0147ec3 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
fix
dccaae8 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
clang-tidy
6381fe8 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
revert core clang-tidy stuff that fails on windows
5eaaef2 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
re-disable sonar
8041f3c 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
minor
d7803ba 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@TonyXiang8787
Copy link
Member

Why are there so many code change? I thought this is only adding new workflow?

@mgovers
Copy link
Member Author

mgovers commented Sep 25, 2024

Why are there so many code change? I thought this is only adding new workflow?

to prove that the workflow does indeed call the correct parameters. I would prefer the first version of the workflow to pass, and then we can start there.

however, there's no target that currently passes in clang-tidy other than the power_grid_model_c target. This adds power_grid_model_cpp to clang-tidy as well.

@mgovers
minor
faadbd9 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
no reference-to-const
1890520 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
more attempt to shut up sonar cloud where it actually needs to
8144221 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mgovers mgovers marked this pull request as ready for review September 26, 2024 08:00
@mgovers mgovers added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit 38de620 Sep 26, 2024
26 checks passed
@mgovers mgovers deleted the feature/add-nightly branch September 26, 2024 09:12
@figueroa1395 figueroa1395 mentioned this pull request Sep 26, 2024
Merged
2 tasks
This was referenced Sep 26, 2024
Closed
Merged
@mgovers mgovers mentioned this pull request Nov 5, 2024
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonyXiang8787 TonyXiang8787 TonyXiang8787 left review comments

@figueroa1395 figueroa1395 figueroa1395 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Nightly build
3 participants
@mgovers @TonyXiang8787 @figueroa1395