Feature / columnar data optional id field support in update data #771

Jerry-Jinfeng-Guo · 2024-10-08T15:37:38Z

This PR implements step 7 of #548

Validation on the combinations of different situations of id
Functionalities to generate sequential id for qualified input
Update columnar component with generated sequence id

AddressSanitizer [https://github.com/BUG in test / Memory access violation in update test #810]
Last but not least: resolve merge conflicts with main
~~Refactor the code to live outside main_model_impl.hpp~~

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

…made easier Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

…te columnar component with sequence Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

…ole pipeline through; one more test to update Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

power_grid_model_c/power_grid_model/include/power_grid_model/component/load_gen.hpp

power_grid_model_c/power_grid_model/include/power_grid_model/component/power_sensor.hpp

power_grid_model_c/power_grid_model/include/power_grid_model/component/voltage_sensor.hpp

power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp

figueroa1395

My computer is forcing an update that requieres restart, I will continue the review later :)

power_grid_model_c/power_grid_model/include/power_grid_model/main_core/update.hpp

power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp

figueroa1395

Finished the whole review.

power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp

tests/cpp_integration_tests/test_main_model.cpp

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

…/row-update-data-support-no-id-field

figueroa1395

Minor comments, and some are left for the refactoring, so feel free to resolve some right away if needed. We are basically there! :D

power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/dataset.hpp

power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp

tests/cpp_integration_tests/test_main_model.cpp

tests/native_api_tests/test_api_model.cpp

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com> Signed-off-by: Martijn Govers <martygovers@hotmail.com>

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com> Signed-off-by: Martijn Govers <martygovers@hotmail.com>

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

…/row-update-data-support-no-id-field Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

…/row-update-data-support-no-id-field

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp

…/row-update-data-support-no-id-field

…upport-no-id-field Feature / row based data optional id field support in update data

This reverts commit e5d5670. Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

sonarqubecloud · 2024-11-05T14:56:40Z

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mgovers · 2024-11-05T14:58:28Z

I think the remaining sonar cloud warnings can be considered out of scope of this PR

Jerry-Jinfeng-Guo added 3 commits October 1, 2024 16:28

branch created

b9f2995

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

added test with no ids

3d1bfcc

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

[skip ci] functionality partially in place; wip

340b740

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

Jerry-Jinfeng-Guo added the feature New feature or request label Oct 8, 2024

Jerry-Jinfeng-Guo self-assigned this Oct 8, 2024

Jerry-Jinfeng-Guo and others added 14 commits October 8, 2024 17:37

Merge branch 'main' into feature/columnar-data-support-no-id-field

1edc403

[skip ci]

8ded552

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

Merge branch 'main' into feature/columnar-data-support-no-id-field

ea6ba47

[skip ci] added logic for has_id and id_nan

575e24d

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

[skip ci] more component level properties

0ea07fa

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

[skip ci] minor fix on the independence criteria

75b1583

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

[skip ci] added elements per scenario of base; subsequent comparison …

721eec4

…made easier Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

[skip ci] added checks

464ed64

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

[skip ci] functionality accepting sequence

d2ce49d

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

[skip ci] functionalities for get sequence in place; next to the upda…

3280fa8

…te columnar component with sequence Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

[skip ci] removing id match assert: incompatible with optional id; wh…

faa5966

…ole pipeline through; one more test to update Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

[skip ci] empty columnar data input supported

88610d2

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

[skip ci] made test more complete; next to merge with main

f584870

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

[skip ci] removed commented code

9a11e6a

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

mgovers reviewed Oct 16, 2024

View reviewed changes

figueroa1395 reviewed Oct 16, 2024

View reviewed changes

Jerry-Jinfeng-Guo and others added 4 commits October 16, 2024 15:24

[skip ci] address some comments

892ca09

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

[skip ci] more comments addressed

ec5bc65

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

[skip ci] one more comment addressed

4d63387

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

Merge branch 'main' into feature/columnar-data-support-no-id-field

b06d8c5

mgovers reviewed Oct 17, 2024

View reviewed changes

power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp Outdated Show resolved Hide resolved

power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp Outdated Show resolved Hide resolved

[skip ci] branch created

890837a

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

Jerry-Jinfeng-Guo mentioned this pull request Oct 17, 2024

Feature / Update Python validation to support optional id in update data #793

Merged

5 tasks

[skip ci] intermediate commit marking several python tests as fail

4ca60bd

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

Merge branch 'feature/columnar-data-support-no-id-field' into feature…

d1f2220

…/row-update-data-support-no-id-field

figueroa1395 reviewed Nov 5, 2024

View reviewed changes

mgovers and others added 13 commits November 5, 2024 13:46

Apply suggestions from code review

0513ffa

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com> Signed-off-by: Martijn Govers <martygovers@hotmail.com>

sonar-cloud

f098446

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

minor

1faab9f

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

Apply suggestions from code review

314af8a

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com> Signed-off-by: Martijn Govers <martygovers@hotmail.com>

more resolve comments

1344c9f

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

fix unused captured variable

d53d3ea

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

fix variable name

02bf930

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

Merge branch 'feature/columnar-data-support-no-id-field' into feature…

aa63dc8

…/row-update-data-support-no-id-field Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>

fix typo

8762766

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

Merge branch 'feature/columnar-data-support-no-id-field' into feature…

cfb4d1a

…/row-update-data-support-no-id-field

fix error introduced from merging

dba5644

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

Merge branch 'main' into feature/columnar-data-support-no-id-field

80d25eb

Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>

fix merge error

0a1ea5d

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

nitbharambe reviewed Nov 5, 2024

View reviewed changes

power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp Show resolved Hide resolved

Jerry-Jinfeng-Guo and others added 5 commits November 5, 2024 15:07

Merge branch 'feature/columnar-data-support-no-id-field' into feature…

69b736b

…/row-update-data-support-no-id-field

Merge pull request #813 from PowerGridModel/feature/row-update-data-s…

2c76f9c

…upport-no-id-field Feature / row based data optional id field support in update data

Revert "remove optional ids tests"

a6320cf

This reverts commit e5d5670. Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

remove pytest mark xfail

849d293

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

format

74f2fef

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

nitbharambe approved these changes Nov 5, 2024

View reviewed changes

figueroa1395 approved these changes Nov 5, 2024

View reviewed changes

Jerry-Jinfeng-Guo added this pull request to the merge queue Nov 5, 2024

mgovers approved these changes Nov 5, 2024

View reviewed changes

Merged via the queue into main with commit 373d9e4 Nov 5, 2024
26 checks passed

Jerry-Jinfeng-Guo deleted the feature/columnar-data-support-no-id-field branch November 5, 2024 15:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature / columnar data optional id field support in update data #771

Feature / columnar data optional id field support in update data #771

Jerry-Jinfeng-Guo commented Oct 8, 2024 •

edited

Loading

figueroa1395 left a comment •

edited

Loading

figueroa1395 left a comment

figueroa1395 left a comment

sonarqubecloud bot commented Nov 5, 2024

mgovers commented Nov 5, 2024

Feature / columnar data optional id field support in update data #771

Feature / columnar data optional id field support in update data #771

Conversation

Jerry-Jinfeng-Guo commented Oct 8, 2024 • edited Loading

figueroa1395 left a comment • edited Loading

Choose a reason for hiding this comment

figueroa1395 left a comment

Choose a reason for hiding this comment

figueroa1395 left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Nov 5, 2024

Quality Gate passed

mgovers commented Nov 5, 2024

Jerry-Jinfeng-Guo commented Oct 8, 2024 •

edited

Loading

figueroa1395 left a comment •

edited

Loading