Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dtype compatibility check #776

Merged
merged 8 commits into from
Oct 14, 2024
Merged

Add dtype compatibility check #776

merged 8 commits into from
Oct 14, 2024

Conversation

nitbharambe
Copy link
Member

Fixes issue: #774

Changes proposed in this PR include:

Add a warning for dtype check. To be changed to error before minor version bump.

@nitbharambe
add compatibility check
39a9bf0 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
mgovers
mgovers reviewed Oct 11, 2024
View reviewed changes
src/power_grid_model/core/power_grid_dataset.py Outdated Show resolved Hide resolved
src/power_grid_model/core/power_grid_dataset.py Outdated Show resolved Hide resolved
src/power_grid_model/core/power_grid_dataset.py Outdated Show resolved Hide resolved
src/power_grid_model/core/power_grid_dataset.py Outdated Show resolved Hide resolved
@nitbharambe
change shape and warning check
5a07636 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
nitbharambe and others added 2 commits October 11, 2024 15:49
@nitbharambe @mgovers
Update src/power_grid_model/core/power_grid_dataset.py
7ad2248 
Co-authored-by: Martijn Govers <martijn.govers@alliander.com>
Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
@nitbharambe
format changes and doc
f90cf37 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
nitbharambe and others added 2 commits October 12, 2024 15:22
@nitbharambe
move to buffer handling
a4ef401 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
Merge branch 'main' into featue/check-compatible-type
ed653cb
@mgovers
Copy link
Member

mgovers commented Oct 13, 2024

This PR should not close #774 . That ticket should be closed when v1.10.0 is released

@nitbharambe
Update src/power_grid_model/core/buffer_handling.py
4fcb6a1 
Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
@nitbharambe nitbharambe marked this pull request as ready for review October 14, 2024 07:20
mgovers
mgovers reviewed Oct 14, 2024
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you can remove the python_grid_meta_data again, or you'll have to wait a bit for me to find a way to document it in #781

docs/api_reference/python-api-reference.md Outdated Show resolved Hide resolved
@nitbharambe
Update docs/api_reference/python-api-reference.md
2737a55 
Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mgovers mgovers enabled auto-merge October 14, 2024 08:04
@mgovers mgovers added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit f295da5 Oct 14, 2024
26 checks passed
@mgovers mgovers deleted the featue/check-compatible-type branch October 14, 2024 09:02
@mgovers mgovers mentioned this pull request Nov 5, 2024
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@figueroa1395 figueroa1395 figueroa1395 left review comments

@TonyXiang8787 TonyXiang8787 TonyXiang8787 left review comments

@mgovers mgovers mgovers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nitbharambe @mgovers @TonyXiang8787 @figueroa1395