Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] - columnar data examples #785

Merged
merged 19 commits into from
Oct 22, 2024
Merged

[Feature] - columnar data examples #785

merged 19 commits into from
Oct 22, 2024

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Oct 15, 2024 •
edited
Loading

Relates to #548 .

@mgovers
rerun examples
9aea54b 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers added the documentation Improvements or additions to documentation label Oct 15, 2024
@mgovers mgovers self-assigned this Oct 15, 2024
@mgovers
rerun state estimation notebook
738ae05 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
add columnar output to pf example
0c0dab7 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
add columnar data formats to power flow example
7f4fc04 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
all attributes as columns in pf notebook
b2d63d6 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
improve section headers
ba5a8a1 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
add columnar data to serialization notebook
414b4c7 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers marked this pull request as ready for review October 17, 2024 06:22
@mgovers
fix formatting of validation error
e7cc8fd 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers and others added 3 commits October 18, 2024 13:38
@mgovers @nitbharambe
Update docs/examples/Power Flow Example.ipynb
97d1059 
Co-authored-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
Signed-off-by: Martijn Govers <martijn.govers@alliander.com>
@mgovers @nitbharambe
Update docs/examples/Serialization Example.ipynb
9c0d586 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

Co-authored-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
Signed-off-by: Martijn Govers <martijn.govers@alliander.com>
@mgovers
apply suggestions
7b6aa7d 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers force-pushed the feature/columnar-data-examples branch from e5eac63 to 7b6aa7d Compare October 18, 2024 11:39
@mgovers
Copy link
Member Author

mgovers commented Oct 18, 2024

code coverage appears to be a false positive

mgovers and others added 5 commits October 21, 2024 11:09
@mgovers
improve coverage by merging error type output
81a812e 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
update pf example
f6cd2be 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Merge branch 'main' into feature/columnar-data-examples
f45797b
@mgovers
rerun notebooks
c9aaeee 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
more code coverage
e9e7995 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
figueroa1395
figueroa1395 reviewed Oct 21, 2024
View reviewed changes
Copy link
Contributor

@figueroa1395 figueroa1395 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, maybe it is good to also mention that the validation function also works for columnar data validation.

docs/examples/Asymmetric Calculation Example.ipynb Show resolved Hide resolved
docs/examples/Power Flow Example.ipynb Show resolved Hide resolved
docs/examples/Power Flow Example.ipynb Show resolved Hide resolved
docs/examples/Power Flow Example.ipynb Show resolved Hide resolved
docs/examples/Power Flow Example.ipynb Outdated Show resolved Hide resolved
docs/examples/Power Flow Example.ipynb Outdated Show resolved Hide resolved
@mgovers
process comments
8220bc7 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
minor elaboration on columnar data
313834a 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
minor elaboration on columnar data
19be23d 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mgovers mgovers added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit 676daa0 Oct 22, 2024
26 checks passed
@mgovers mgovers deleted the feature/columnar-data-examples branch October 22, 2024 07:16
@mgovers mgovers mentioned this pull request Nov 5, 2024
Closed
27 tasks
@figueroa1395 figueroa1395 mentioned this pull request Nov 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitbharambe nitbharambe nitbharambe left review comments

@figueroa1395 figueroa1395 figueroa1395 approved these changes

Assignees

@mgovers mgovers

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgovers @figueroa1395 @nitbharambe