Feature/private core module

[mgovers]

Closes #784

Notes to reviewer:

review commit-by-commit. that's much easier

• reviewed 3aa2ee5
• reviewed 6ca7e5c
• reviewed ee1cdf9
• reviewed any newer commits

[figueroa1395]

Reviewed 3aa2ee5. Only minor comments.

[figueroa1395]

Reviewed 6ca7e5c: Looks good, the only worry I have is that since this task can be very cherry-pickish (We have to cherry pick all, but still...), I hope we don't miss exposing one functionality from the core and hence break anyones workflow.

[figueroa1395]

Reviewed ee1cdf9: All looks good, code generation check comming to the rescue here! ;)

[TonyXiang8787]

Do we really need this? I propose to change it to _core immediately. No warnings, just error.

When we released PGM, we made it very clear that Python stuff which is not documented in the read the docs is not public API and not supported.

[mgovers]

Do we really need this? I propose to change it to _core immediately. No warnings, just error.

When we released PGM, we made it very clear that Python stuff which is not documented in the read the docs is not public API and not supported.

i'm all for that but it may break users' code. i propose to remove this (temp) library at the same time when we actually do the version bump, so that users can specify that. let's discuss tomorrow @petersalemink95

[mgovers]

cfr. discussions: this will be merged in the same PR that will bump the version to v1.10.0

[figueroa1395]

Re re-ran all the examples and checked the changes again. All looks good.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud