Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/attribute-dtype-helper-function #834

Merged
merged 6 commits into from
Nov 18, 2024
Merged

Feature/attribute-dtype-helper-function #834

merged 6 commits into from
Nov 18, 2024

Conversation

nitbharambe
Copy link
Member

@nitbharambe nitbharambe commented Nov 18, 2024 •
edited
Loading

Fixes issue: #786

Changes proposed in this PR include:

New helper functions for columnar data attribute_dtype and attribute_empty_value

@nitbharambe
add helper function
66ab1f9 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add tests
f1844f3 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add docs example
6678b59 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
change import order
d2faa4b 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe nitbharambe marked this pull request as ready for review November 18, 2024 07:40
@nitbharambe
Update src/power_grid_model/_core/power_grid_meta.py
daf5884 
Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
mgovers
mgovers reviewed Nov 18, 2024
View reviewed changes
docs/examples/Power Flow Example.ipynb Outdated Show resolved Hide resolved
docs/examples/Power Flow Example.ipynb Outdated Show resolved Hide resolved
tests/unit/test_meta_data.py Show resolved Hide resolved
@nitbharambe
address comments
bc0d149 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nitbharambe
Copy link
Member Author

Thanks @figueroa1395 !
Since this is adding to API, @TonyXiang8787 can you also check it off?

@nitbharambe nitbharambe added the do-not-merge This should not be merged label Nov 18, 2024
@TonyXiang8787 TonyXiang8787 removed the do-not-merge This should not be merged label Nov 18, 2024
@TonyXiang8787 TonyXiang8787 added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit d168e2d Nov 18, 2024
28 of 29 checks passed
@TonyXiang8787 TonyXiang8787 deleted the feature/attribute-dtype-helper-function branch November 18, 2024 16:04
@TonyXiang8787 TonyXiang8787 linked an issue Nov 21, 2024 that may be closed by this pull request
[FEATURE] Columnar data creation helper function #786
Closed
@TonyXiang8787 TonyXiang8787 added the feature New feature or request label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgovers mgovers mgovers left review comments

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo left review comments

@figueroa1395 figueroa1395 figueroa1395 approved these changes

@TonyXiang8787 TonyXiang8787 TonyXiang8787 approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Columnar data creation helper function
5 participants
@nitbharambe @Jerry-Jinfeng-Guo @mgovers @TonyXiang8787 @figueroa1395