Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename get_component_sequence in state_queries.hpp #836

Conversation

figueroa1395
Copy link
Contributor

Quick PR to rename get_component_sequence to get_component_sequence_idx from state_queries.hpp since it returns a sequence index, not a sequence itself.

Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
@figueroa1395 figueroa1395 self-assigned this Nov 19, 2024
@figueroa1395 figueroa1395 added the improvement Improvement on internal implementation label Nov 19, 2024
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo marked this pull request as ready for review November 19, 2024 09:34
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo merged commit 8cabc92 into feature/optional-id-refactor-part2 Nov 19, 2024
26 checks passed
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo deleted the get_component_sequence-refactor branch November 19, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement on internal implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants