Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparse matrix error: repro case for not using numerical pivoting #852

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

TonyXiang8787
Copy link
Member

The in-house LU Sparse solver does not do numerical pivoting for performance optimization. It assumes that the matrix is always diagonal major.

However, this assumption does not hold for certain real-world state estimation cases. This results in Sparse Matrix Error where the system is actually perfectly observable and solvable.

This PR reproduces the error using two cases.

Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
Copy link
Member Author

@mgovers please go ahead to modify the files, merge the PR and create the issue.

@mgovers
Copy link
Member

mgovers commented Dec 6, 2024

Issue created in #853

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers marked this pull request as ready for review December 6, 2024 08:31
@mgovers mgovers enabled auto-merge December 6, 2024 08:31
@mgovers mgovers changed the title [BUG] Sparse matrix error because of not using numerical pivoting Sparse matrix error: repro case for not using numerical pivoting Dec 6, 2024
@mgovers mgovers added the bug Something isn't working label Dec 6, 2024
Copy link

sonarqubecloud bot commented Dec 6, 2024

@mgovers mgovers added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit 266623e Dec 6, 2024
29 checks passed
@mgovers mgovers deleted the bug/sparse-matrix-error-not-numerical-pivotting branch December 6, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants