Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

current sensor skeleton #861

Merged
merged 43 commits into from
Jan 9, 2025
Merged

current sensor skeleton #861

merged 43 commits into from
Jan 9, 2025

Conversation

petersalemink95
Copy link
Member

Creates a skeleton for #547.

@petersalemink95
angle measurement type enum
66ce29b 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
current sensor input
411f160 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
current sensor update
51c972d 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
current sensor output
8480a5f 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
current sensor file with license
8dc4374 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
add measured terminal type to input
5c09d74 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
generic current sensor + empty test file
083b2bf 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
disable mypy call-overload
2c71a55 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
petersalemink95
petersalemink95 commented Dec 24, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@petersalemink95
change sigma
a0609c7 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
CurrentSensorCalcParam
b464409 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
CurrentSensor template
ca09197 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
Revert "change sigma"
7c32e89 
This reverts commit a0609c7.
@petersalemink95
i_angle_sigma in constructor
dade513 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
calculate + use base_current
235c14e 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
i angle sigma without division
901107d 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
use scalar
8a30ac7 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
add dummy variables for passing build
5983d7f 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
DCO Remediation Commit for petersalemink95 <peter.salemink95@gmail.com>
5db6375 
I, petersalemink95 <peter.salemink95@gmail.com>, hereby add my Signed-off-by to this commit: 7c32e89

Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
calc param with separate i and i_angle variance
768037e 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
first tests - temp save
48656f6 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
unused vairables
513ce1e 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
passing tests
812f018 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
fill update function
d1fbb47 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
implement inverse + test sym inverse
d9c5ab2 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
fix scalars
19ca13f 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
test asym inverse
b1ca230 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
move comment
285f5f6 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
double variances
87fb7c1 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
merge
30267eb 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
add angle measurement type to calc param
4885381 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
figueroa1395
figueroa1395 reviewed Jan 3, 2025
View reviewed changes
code_generation/data/attribute_classes/output.json Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/component/current_sensor.hpp Show resolved Hide resolved
code_generation/data/attribute_classes/input.json Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/component/current_sensor.hpp Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/component/current_sensor.hpp Outdated Show resolved Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/calculation_parameters.hpp Outdated Show resolved Hide resolved
tests/cpp_unit_tests/test_current_sensor.cpp Outdated Show resolved Hide resolved
tests/cpp_unit_tests/test_current_sensor.cpp Show resolved Hide resolved
tests/cpp_unit_tests/test_current_sensor.cpp Outdated Show resolved Hide resolved
tests/cpp_unit_tests/test_current_sensor.cpp Outdated Show resolved Hide resolved
petersalemink95 and others added 7 commits January 7, 2025 08:39
@petersalemink95
use inv_sqrt3
ac3511e 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
Merge branch 'main' into feature/current-sensor-skeleton
e0eb9e4
@petersalemink95
remove convert_direction + test only branch
da8c0ce 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
only accept branches
3691a73 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
single base_current_
f30dd34 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
update switch statement
00ab5e5 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
fix indent
c250f3b 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
update calc_param
87b323f 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
use scalar
dc5310a 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@petersalemink95
base_current_inv_
1d149ac 
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@petersalemink95 petersalemink95 added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 8534402 Jan 9, 2025
28 checks passed
@petersalemink95 petersalemink95 deleted the feature/current-sensor-skeleton branch January 9, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitbharambe nitbharambe nitbharambe left review comments

@figueroa1395 figueroa1395 figueroa1395 left review comments

@TonyXiang8787 TonyXiang8787 TonyXiang8787 left review comments

@mgovers mgovers mgovers left review comments

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@petersalemink95 @Jerry-Jinfeng-Guo @mgovers @TonyXiang8787 @figueroa1395 @nitbharambe