optimize loop logic #497
Merged
optimize loop logic #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
感谢你的工作，这看上去优化的性能并且没有引入其他问题 我有些没有理解哈希表在这里的意义，我们是要创建一个底层是哈希表的 Map<T, T> 吗，你准备怎么改进这里的数据结构 |
|
通过 pluginsController.pluginHTTPList 创建规则仓库中 Map<name,version>的映射，然后遍历 pluginsController.pluginList 判断规则是否更新， 这样就不需要两个for循环嵌套 |
|
可以那么做。但我觉得增加了复杂度 规则最多几十条，没有必要在这里进行这样的性能优化 |
|
ok，我也觉得现在这样代码量不多也挺好的 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
优化break逻辑。
为什么不用哈希表，数据太少没必要吗