Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod history card #567

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Mod history card #567

merged 3 commits into from
Jan 6, 2025

Conversation

ErBWs
Copy link
Contributor

@ErBWs ErBWs commented Jan 6, 2025

#566

我看一直没回复就擅自 PR 了

@xxfttkx
Copy link
Contributor

xxfttkx commented Jan 6, 2025

改draft了没邮件提醒没注意,不过我找出来的方法是添加padding: const EdgeInsets.all(0)来取消PopupMenuButton的阴影,你这改Icon颜色能让鼠标悬停也表现正常吗,先用你的看看效果吧,我那个close了

@Predidit
Copy link
Owner

Predidit commented Jan 6, 2025

这个PR的效果非常好,并且是先完成的

我会合并这个PR

@Predidit Predidit merged commit 28859ae into Predidit:main Jan 6, 2025
6 checks passed
@ErBWs ErBWs deleted the mod-history-card branch January 6, 2025 14:19
@xxfttkx
Copy link
Contributor

xxfttkx commented Jan 6, 2025

image
会导致info page的按钮失去颜色

@ErBWs
Copy link
Contributor Author

ErBWs commented Jan 6, 2025

噢我忘了这个界面也有按钮,没做测试

@Predidit
Copy link
Owner

Predidit commented Jan 6, 2025

我测试时也没注意到这个按钮,也许我们需要另一个 PR 来修复这个问题

@Predidit
Copy link
Owner

Predidit commented Jan 6, 2025

这个问题不好修,感觉不如在这个页面上用 stack 叠一下

@ErBWs
Copy link
Contributor Author

ErBWs commented Jan 6, 2025

改draft了没邮件提醒没注意,不过我找出来的方法是添加padding: const EdgeInsets.all(0)来取消PopupMenuButton的阴影,你这改Icon颜色能让鼠标悬停也表现正常吗,先用你的看看效果吧,我那个close了

@xxfttkx 核心问题不是icon颜色,是 PopupMenuButton 中 child 和 icon 的区别
image
image

@xxfttkx
Copy link
Contributor

xxfttkx commented Jan 6, 2025

@ErBWs
我在使用icon后圆按钮外仍有一层圆阴影,使用padding: const EdgeInsets.all(0)后解决了。

ErBWs added a commit to ErBWs/Kazumi that referenced this pull request Jan 6, 2025
ErBWs added a commit to ErBWs/Kazumi that referenced this pull request Jan 6, 2025
@ErBWs ErBWs mentioned this pull request Jan 6, 2025
@ErBWs
Copy link
Contributor Author

ErBWs commented Jan 6, 2025

@ErBWs 我在使用icon后圆按钮外仍有一层圆阴影,使用padding: const EdgeInsets.all(0)后解决了。

@xxfttkx 圆形阴影应该没有什么问题,原来的表现问题在于会出现超出圆形边框的方形阴影

另外直接移动 Positioned 的方法控制台会报错,提示错误的 Positioned 使用位置

Predidit added a commit that referenced this pull request Jan 6, 2025
ErBWs added a commit to ErBWs/Kazumi that referenced this pull request Jan 8, 2025
(cherry picked from commit 6acf359)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants