Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix comments bug when changing episode #573

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Conversation

ErBWs
Copy link
Contributor

@ErBWs ErBWs commented Jan 8, 2025

不保存状态了,用 Sliver 的懒加载解决卡顿问题

另外现在的播放器有两个问题

  • 手机端切换全屏会导致 player_item_panel 消失

  • 控制台报异常(这个把 player_item_panel 的 build 里最顶层的 Expanded 删了可以解决)

======== Exception caught by widgets library =======================================================
The following assertion was thrown while applying parent data.:
Incorrect use of ParentDataWidget.

The ParentDataWidget Expanded(flex: 1) wants to apply ParentData of type FlexParentData to a RenderObject, which has been set up to accept ParentData of incompatible type StackParentData.

Usually, this means that the Expanded widget has the wrong ancestor RenderObjectWidget. Typically, Expanded widgets are placed directly inside Flex widgets.
The offending Expanded is currently placed inside a Stack widget.

The ownership chain for the RenderObject that received the incompatible parent data was:
  Stack ← Observer ← Expanded ← PlayerItemPanel ← Stack ← SizedBox ← Listener ← MouseRegion ← ColoredBox ← Container ← ⋯

@Predidit
Copy link
Owner

Predidit commented Jan 8, 2025

那我们可以把 Expanded 删掉,看上去不会有什么问题

@ErBWs ErBWs changed the title Fix player fix comments bug when changing episode Jan 8, 2025
@ErBWs
Copy link
Contributor Author

ErBWs commented Jan 8, 2025

但是第一个问题不知道什么原因,控制台也没报错,所以我就没改这个文件

@Predidit
Copy link
Owner

Predidit commented Jan 8, 2025

是我的问题,我考虑一下怎么修

@Predidit Predidit merged commit 74f3467 into Predidit:main Jan 8, 2025
6 checks passed
@ErBWs ErBWs deleted the fix-player branch January 8, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants