optimize volume code #585
Merged
optimize volume code #585
+16
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
很棒的代码优化 不过我对允许超过 100% 的音量调节持保留意见，这看上去会使桌面和移动设备出现更多的不一致 |
|
那保持现在吧，超过100的音量设置也担心有隐患，或许感觉声音小时升级硬件是更正常的做法 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
优化音量控制代码。
问个问题，有的番剧就算音量拉满也感觉还是太小声。我尝试把volume的最大值改成200，即在setVolume中
value = value.clamp(0.0, 200.0);，发现是能正常工作的，似乎mpv支持这种设置。项目是否考虑这个功能。