This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
push_to_s3 and pull_from_s3 do not support additional AwsCredentials block parameters #313
Closed
1 task done
Expectation / Proposal
deployments.steps:push_to_s3
anddeployments.steps:pull_from_s3
do not support certain properties on the AwsCredentials block (profile_name, aws_client_parameters), causing the call to boto3.client to fail with bad parameters.The processing of credentials and client_parameters in these functions does not match the signature of the resolved block input from a loaded AwsCredentials block. When
**inputs
is passed toCall.new
inprefect\deployments\steps\core.py
the block is resolved as with the signatureAnd then things like
profile_name
andaws_client_parameters
are not recognized as kwargs for the boto3.client command.I propose a function to process the AwsCredentials block signature to something that boto3.client supports.
Traceback / Example
The text was updated successfully, but these errors were encountered: