This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Read AWS Secrets with 'SecretString' #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desertaxle
suggested changes
Jun 7, 2023
There was a problem hiding this comment.
Thanks for contributing @nick-amplify! Could you please add some tests covering this new functionality?
Co-authored-by: Alexander Streed <desertaxle@users.noreply.github.com>
|
@nick-amplify just checking to see if you can write some tests for this PR 🙂 |
|
I'm curious if this PR will make it into the main branch any time soon? We are wanting to leverage the SecretString functionality as all of our Secrets are in SecretString format and not SecretBinary. Thanks in advance! |
desertaxle
approved these changes
Nov 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #265
Example
Screenshots
Checklist
pre-commitchecks.pre-commit install && pre-commit run --alllocally for formatting and linting.