Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Read AWS Secrets with 'SecretString' #274

Merged
merged 7 commits into from
Nov 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added

### Changed
- Added 'SecretBrinary' suport to `AwsSecret` block - [#274](https://github.com/PrefectHQ/prefect-aws/pull/274)

### Fixed

Expand Down
5 changes: 4 additions & 1 deletion prefect_aws/secrets_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,10 @@ async def read_secret(
response = await run_sync_in_worker_thread(
client.get_secret_value, SecretId=self.secret_name, **read_kwargs
)
secret = response["SecretBinary"]
if "SecretBinary" in response:
secret = response["SecretBinary"]
elif "SecretString" in response:
secret = response["SecretString"]
arn = response["ARN"]
self.logger.info(f"The secret {arn!r} data was successfully read.")
return secret
Expand Down
7 changes: 7 additions & 0 deletions tests/test_secrets_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -199,3 +199,10 @@ def test_delete_secret_recovery_window(self, aws_secret: AwsSecret):
ValueError, match="Recovery window must be between 7 and 30 days"
):
aws_secret.delete_secret(recovery_window_in_days=42)

async def test_read_secret(self, secret_under_test, aws_credentials):
secret = AwsSecret(
aws_credentials=aws_credentials,
secret_name=secret_under_test["secret_name"],
)
assert await secret.read_secret() == secret_under_test["expected_value"]