Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

dont break on debug logs #296

Merged
merged 5 commits into from
Jul 14, 2023
Merged
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions prefect_aws/workers/ecs_worker.py
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,9 @@ def _create_task_and_wait_for_start(
_TASK_DEFINITION_CACHE[flow_run.deployment_id] = task_definition_arn

logger.info(f"Using ECS task definition {task_definition_arn!r}...")
logger.debug(f"Task definition {json.dumps(task_definition, indent=2)}")
logger.debug(
f"Task definition {json.dumps(task_definition, indent=2, default=str)}"
)

# Prepare the task run request
task_run_request = self._prepare_task_run_request(
Expand All @@ -686,7 +688,9 @@ def _create_task_and_wait_for_start(
)

logger.info("Creating ECS task run...")
logger.debug(f"Task run request {json.dumps(task_run_request, indent=2)}")
logger.debug(
f"Task run request {json.dumps(task_run_request, indent=2, default=str)}"
)
try:
task = self._create_task_run(ecs_client, task_run_request)
task_arn = task["taskArn"]
Expand Down Expand Up @@ -861,7 +865,10 @@ def _register_task_definition(
Returns the ARN.
"""
logger.info("Registering ECS task definition...")
logger.debug(f"Task definition request {json.dumps(task_definition, indent=2)}")
logger.debug(
"Task definition request"
f"{json.dumps(task_definition, indent=2, default=str)}"
)
response = ecs_client.register_task_definition(**task_definition)
return response["taskDefinition"]["taskDefinitionArn"]

Expand Down