Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

fix ssl default #328

Merged
merged 4 commits into from
Nov 6, 2023
Merged

fix ssl default #328

merged 4 commits into from
Nov 6, 2023

Conversation

j-tr
Copy link
Contributor

@j-tr j-tr commented Oct 24, 2023

Closes #327

The boto3 client parameter use_ssl defaults to True. Setting it to None here contradicts the default and causes uploads to SSL-only buckets to fail.
Allowing SSL only on S3 is AWS best practice https://docs.aws.amazon.com/AmazonS3/latest/userguide/security-best-practices.html and therefore, this should work without the need to explicitly set use_ssl to true in the client parameters.

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.
  • Summarizes PR's changes in CHANGELOG.md

@j-tr j-tr requested a review from a team as a code owner October 24, 2023 16:03
@j-tr
Copy link
Contributor Author

j-tr commented Nov 6, 2023

@desertaxle would it be possible to get some feedback on this?

CHANGELOG.md Outdated Show resolved Hide resolved
@desertaxle desertaxle merged commit f8a26eb into PrefectHQ:main Nov 6, 2023
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

boto3 client use_ssl wrong default
2 participants