-
Notifications
You must be signed in to change notification settings - Fork 40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like the direction!
- Could you please add a screenshot of the Mermaid diagram to the PR?
- Looks like there are some merge conflicts that need resolved.
…ecs-worker-setup-guide-fixes
There's a reference on line 5 to "Prefect 2" which I think we can change to just "Prefect" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor style things.
Thank you so much @jeanluciano for taking this on!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. A few comments/suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Added one suggested change for title case consistency.
docs/ecs_guide.md
Outdated
|
||
### 5. Find the deployment in the UI and click the **Quick Run** button! | ||
|
||
## Optional Next Steps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Optional Next Steps | |
## Optional next steps |
Closes #394
Example
Graph updated to used Prefect colors, open to different color values:
Screenshots
Checklist
pre-commit
checks.pre-commit install && pre-commit run --all
locally for formatting and linting.mkdocs serve
view documentation locally.