Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

support python 3.10 with ray >= 2.0 #105

Merged
merged 5 commits into from
Nov 29, 2023

Conversation

j-tr
Copy link
Contributor

@j-tr j-tr commented Nov 27, 2023

Closes #104

Example

Ray supports Python 3.10 from version 2.0.0.

Screenshots

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.
  • Summarizes PR's changes in CHANGELOG.md

@j-tr j-tr requested a review from a team as a code owner November 27, 2023 14:57
@j-tr
Copy link
Contributor Author

j-tr commented Nov 27, 2023

@desertaxle please let me know if you think further changes are necessary in order to support Python 3.10.

Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @j-tr! We also would want to add tests for Python 3.10 in our CI process. That should be as simple as commenting out this line:

.

setup.py Outdated
@@ -36,6 +36,7 @@
"Programming Language :: Python :: 3.7",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefect doesn't support 3.7 so we can drop this line as well.

Suggested change
"Programming Language :: Python :: 3.7",

CHANGELOG.md Outdated

### Added

- Support Python 3.10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Support Python 3.10
- Support for Python 3.10 - [#105](https://github.com/PrefectHQ/prefect-ray/pull/105)

@j-tr j-tr requested a review from desertaxle November 29, 2023 14:33
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@desertaxle desertaxle merged commit bcc02d8 into PrefectHQ:main Nov 29, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.10 support
2 participants