v3.0.2 #276
Open
v3.0.2 #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nicosomb
commented
Aug 29, 2024
nicosomb
commented
| Questions | Answers |
|---|---|
| Description? | PR for release v3.0.2 |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | |
| Sponsor company | PrestaShop SA |
| How to test? | Test the whole module behaviours |
Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2. - [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md) - [Commits](browserify/browserify-sign@v4.2.1...v4.2.2) --- updated-dependencies: - dependency-name: browserify-sign dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…erify-sign-4.2.2 Bump browserify-sign from 4.2.1 to 4.2.2
Use npm ci instead of npm install
Standardize upgrade files
Bump version number to 3.0.2
|
@florine2623 I can't reproduce statistics and "add to wishlist" bug. Could you try again or tell me in details how I can reproduce them please? |
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.1.7. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v3...v4.1.7) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…-github/workflows/actions/download-artifact-4.1.7 Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows
|
Hello @nicosomb, I tested the PR and I found a bug.
Step to reproduce :
|
|
it seems that these bugs are already in v3.0.1. So it's not related to this PR. |
florine2623
reviewed
Sep 6, 2024
There was a problem hiding this comment.
Hello @nicosomb ,
Tested these bugs with v3.0.1 and branch dev.
I have some news errors not mentioned previously in this PR.
Following @paulnoelcholot 's comment, I have this error :
Screen.Recording.2024-09-06.at.11.23.19.mov
The controller for URI "/modules/blockwishlist/statistics" is not callable: Controller "PrestaShop\Module\BlockWishList\Controller\WishlistConfigurationAdminController" has required constructor arguments and does not exist in the container. Did you forget to define the controller as a service?
I don't think it's a good idea to validate this PR if it cannot be tested properly and if some big exceptions are displayed. Sorry 😭
Maybe we should block this release until at least some of these errors are fixed ?
WDTY ?
Bumps [@prestashop-core/ui-testing](https://github.com/PrestaShop/ui-testing-library) from `7fe2864` to `308f64a`. - [Release notes](https://github.com/PrestaShop/ui-testing-library/releases) - [Commits](PrestaShop/ui-testing-library@7fe2864...308f64a) --- updated-dependencies: - dependency-name: "@prestashop-core/ui-testing" dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
…/UI/dev/prestashop-core/ui-testing-308f64a Bump @prestashop-core/ui-testing from `7fe2864` to `308f64a` in /tests/UI
|
@paulnoelcholot about your bug, there is already an opened issue PrestaShop/PrestaShop#33374 |
|
@florine2623 the first bug is fixed in #280 |
kpodemski
approved these changes
Sep 11, 2024
Bumps [@prestashop-core/ui-testing](https://github.com/PrestaShop/ui-testing-library) from `308f64a` to `6d4977d`. - [Release notes](https://github.com/PrestaShop/ui-testing-library/releases) - [Commits](PrestaShop/ui-testing-library@308f64a...6d4977d) --- updated-dependencies: - dependency-name: "@prestashop-core/ui-testing" dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
…/UI/dev/prestashop-core/ui-testing-6d4977d Bump @prestashop-core/ui-testing from `308f64a` to `6d4977d` in /tests/UI
Bumps [serve-static](https://github.com/expressjs/serve-static) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together. Updates `serve-static` from 1.15.0 to 1.16.2 - [Release notes](https://github.com/expressjs/serve-static/releases) - [Changelog](https://github.com/expressjs/serve-static/blob/v1.16.2/HISTORY.md) - [Commits](expressjs/serve-static@v1.15.0...v1.16.2) Updates `express` from 4.19.2 to 4.21.0 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md) - [Commits](expressjs/express@4.19.2...4.21.0) --- updated-dependencies: - dependency-name: serve-static dependency-type: indirect - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…/UI/multi-d66d039ac5 Bump serve-static and express in /tests/UI
Bumps [@prestashop-core/ui-testing](https://github.com/PrestaShop/ui-testing-library) from `6d4977d` to `e1abc74`. - [Release notes](https://github.com/PrestaShop/ui-testing-library/releases) - [Commits](PrestaShop/ui-testing-library@6d4977d...e1abc74) --- updated-dependencies: - dependency-name: "@prestashop-core/ui-testing" dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
…/UI/dev/prestashop-core/ui-testing-e1abc74 Bump @prestashop-core/ui-testing from `6d4977d` to `e1abc74` in /tests/UI
Bumps [@prestashop-core/ui-testing](https://github.com/PrestaShop/ui-testing-library) from `e1abc74` to `9b51e9a`. - [Release notes](https://github.com/PrestaShop/ui-testing-library/releases) - [Commits](PrestaShop/ui-testing-library@e1abc74...9b51e9a) --- updated-dependencies: - dependency-name: "@prestashop-core/ui-testing" dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
…/UI/dev/prestashop-core/ui-testing-9b51e9a Bump @prestashop-core/ui-testing from `e1abc74` to `9b51e9a` in /tests/UI
Fixed undefined array key category_name in statistics
Hlavtox
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.