Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add form modifications for feature-value migrated form #859

Closed
wants to merge 3 commits into from
Closed

Add form modifications for feature-value migrated form #859

wants to merge 3 commits into from

Conversation

zuk3975
Copy link
Contributor

@zuk3975 zuk3975 commented Jun 28, 2023 •
edited
Loading

Questions Answers
Description? Adds fields url and meta_title fields to migrated feature value form in BO.
Type? refacto
BC breaks? no
Deprecations? no
Fixed ticket? related to almost finished migration of Features BO form - PrestaShop/PrestaShop#33015
How to test? Use the following PR branch PrestaShop/PrestaShop#33051 - and check that feature value form has additional url and meta_title fields added. Then we will be able to update module version and release it.

This change is Reviewable

@zuk3975 zuk3975 force-pushed the feature-value-migrated-fields branch 4 times, most recently from aa64721 to b07545f Compare June 28, 2023 14:14
@zuk3975
Copy link
Contributor Author

zuk3975 commented Jun 28, 2023

what version should I make it?
3.12.1 -> 3.12.2 ?

jolelievre
jolelievre previously approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zuk3975

@jolelievre jolelievre changed the title add form modifications for feature-value migrated form Add form modifications for feature-value migrated form Jun 28, 2023
boherm
boherm previously approved these changes Jun 28, 2023
View reviewed changes
@zuk3975
Copy link
Contributor Author

zuk3975 commented Jun 29, 2023

what version should I make it? 3.12.1 -> 3.12.2 ?

@jolelievre
I see approvals already, but shouldn't I update the module version? I wasn't 100% about that one ⬆️

@zuk3975 zuk3975 mentioned this pull request Jun 29, 2023
Merged
@zuk3975 zuk3975 dismissed stale reviews from boherm and jolelievre via 53b9279 June 29, 2023 15:16
jolelievre
jolelievre previously approved these changes Jun 30, 2023
View reviewed changes
kpodemski
kpodemski requested changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing upgrade file modification.

@ps-jarvis ps-jarvis added the waiting for author Waiting for author's feedback label Jun 30, 2023
@kpodemski kpodemski added this to the 3.13.0 milestone Jun 30, 2023
kpodemski
kpodemski previously approved these changes Jun 30, 2023
View reviewed changes
@kpodemski kpodemski removed the waiting for author Waiting for author's feedback label Jun 30, 2023
@zuk3975 zuk3975 force-pushed the feature-value-migrated-fields branch from 2309276 to ad4ac9f Compare June 30, 2023 10:18
@djoelleuch
Copy link

Hello @zuk3975
some checks where not successful could you please check .
thank you .

@djoelleuch djoelleuch added waiting for author Waiting for author's feedback and removed Waiting for QA labels Jun 30, 2023
@zuk3975 zuk3975 closed this Jul 1, 2023
@zuk3975 zuk3975 reopened this Jul 1, 2023
@zuk3975 zuk3975 closed this Jul 1, 2023
@zuk3975 zuk3975 reopened this Jul 1, 2023
@zuk3975 zuk3975 force-pushed the feature-value-migrated-fields branch from ad4ac9f to 8b27ae6 Compare July 1, 2023 10:03
@zuk3975
Copy link
Contributor Author

zuk3975 commented Jul 1, 2023 •
edited
Loading

Only now I've noticed that I've created additional branch in this repo instead of making PR from my fork. Idk if that was causing the build to fail, but I've created a new one the right way now. #862

@zuk3975 zuk3975 closed this Jul 1, 2023
@zuk3975 zuk3975 deleted the feature-value-migrated-fields branch July 1, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpodemski kpodemski kpodemski approved these changes

@boherm boherm boherm left review comments

@jolelievre jolelievre Awaiting requested review from jolelievre

Assignees
No one assigned
Labels
waiting for author Waiting for author's feedback
Projects
PR Dashboard
Archived in project
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.
6 participants
@zuk3975 @djoelleuch @kpodemski @jolelievre @boherm @ps-jarvis