Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing form fields in migrated FeatureValue form #862

Merged
merged 3 commits into from
Jul 5, 2023
Merged

Add missing form fields in migrated FeatureValue form #862

merged 3 commits into from
Jul 5, 2023

Conversation

zuk3975
Copy link
Contributor

@zuk3975 zuk3975 commented Jul 1, 2023 •
edited
Loading

Questions Answers
Description? Adds fields url and meta_title fields to migrated feature value form in BO.
Type? refacto
BC breaks? no
Deprecations? no
Fixed ticket? related to almost finished migration of Features BO form - PrestaShop/PrestaShop#33015
How to test? Use the following PR branch PrestaShop/PrestaShop#33051 - and check that feature value form has additional url and meta_title fields added. Also test 8.1 branch to see there is no regression.

This change is Reviewable

@zuk3975 zuk3975 mentioned this pull request Jul 1, 2023
Closed
@zuk3975 zuk3975 changed the title Feature value migrated fields Add missing form fields in migrated FeatureValue form Jul 1, 2023
@zuk3975 zuk3975 mentioned this pull request Jul 1, 2023
Merged
jolelievre
jolelievre approved these changes Jul 1, 2023
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zuk3975

@djoelleuch djoelleuch self-assigned this Jul 4, 2023
djoelleuch
djoelleuch approved these changes Jul 4, 2023
View reviewed changes
Copy link

@djoelleuch djoelleuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @zuk3975 ,
Tested with PS 8.1 /branch develop => OK
So, it's QA ✔️
Thank You 🚀 !

@zuk3975
Copy link
Contributor Author

zuk3975 commented Jul 5, 2023

Hi @djoelleuch you must also test with this PR PrestaShop/PrestaShop#33051 to see that the new migrated feature page has the fields as well.

@nicosomb nicosomb added this to the 3.13.0 milestone Jul 5, 2023
@nicosomb nicosomb merged commit 34b8afc into PrestaShop:dev Jul 5, 2023
@nicosomb
Copy link
Contributor

nicosomb commented Jul 5, 2023

Thank you @zuk3975 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djoelleuch djoelleuch djoelleuch approved these changes

@jolelievre jolelievre jolelievre approved these changes

Assignees

@djoelleuch djoelleuch

Labels
QA ✔️
Projects
PR Dashboard
Archived in project
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zuk3975 @nicosomb @jolelievre @djoelleuch