Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filters checkbox state in editing template; #873

Closed
wants to merge 1 commit into from
Closed

Add filters checkbox state in editing template; #873

wants to merge 1 commit into from

Conversation

fatm-dev
Copy link

@fatm-dev fatm-dev commented Jul 7, 2023 •
edited by eternoendless
Loading

Questions Answers
Description? Added check if filter's id is in filter array in template editing filter checkboxes. Moved layered_selection_ag to new variable cause its repeating 3 times.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#32987
How to test? See PrestaShop/PrestaShop#32987

This change is Reviewable

@Hlavtox
Copy link
Contributor

Hlavtox commented Jul 17, 2023

Will be fixed by #881 - the checkboxes are checked by javascript.

@Hlavtox Hlavtox closed this Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Faceted_search Filter disabled and cannot be enabled
2 participants
@fatm-dev @Hlavtox