-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve wording, add hints, fix javascript form validation #891
Conversation
Ping @kpodemski |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, I just have one question about a generated css file that is modified
@@ -1 +1 @@ | |||
{"version":3,"file":"front.css","mappings":"AAkBA,iBACE,MAAO,CACP,KAAM,CACN,UAAW,CACX,WAAY,CACZ,cAAe,CACf,mCAAuC,CACvC,WAAY,CAPd,iCAUI,MAAO,CACP,KAAM,CACN,UAAW,CACX,WAAY,CACZ,iBAAkB,CAdtB,mCAkBI,QAAS,CACT,iBAAkB,CAClB,OAAQ,CACR,+BAAgC,CArBpC,0BAyBI,UAAW,CACX,WAAY,CACZ,oBAAqB,CACrB,gBAAiB,CACjB,mCAAuC,CACvC,qBAAsB,CACtB,iCAAkC,CAClC,kBAAmB,CACnB,kBAAmB,CACpB,gBAID,KACE,wBAAyB;;ACvC7B,wDAGM,gBAAiB,CACjB,cAAe,CAJrB,kCAQI,eAAgB,CARpB,6CAYM,UAAW,CACX,WAAY,CACZ,eAAgB,CAChB,qBAAsB,CAf5B,sCAmBI,WAAY;;ACZhB,8BAGM,YAAa,CAHnB,8CAKQ,gBAAiB,CALzB,oCANE,uBAAwB,CACxB,eAAgB,CAChB,sBAAuB,CACvB,kBAAmB,CAGrB,oCAcM,UAAW,CACX,eAAgB,CAftB,uGAkBQ,QAAS,CACT,cAAe,CAnBvB,2CAsBQ,aAAc,CAtBtB,sCANE,uBAAwB,CACxB,eAAgB,CAChB,sBAAuB,CACvB,kBAAmB","sources":["webpack://ps_facetedsearch/./_dev/front/overlay.scss","webpack://ps_facetedsearch/./_dev/front/slider.scss","webpack://ps_facetedsearch/./_dev/front/facet.scss"],"sourcesContent":["/**\n * Copyright since 2007 PrestaShop SA and Contributors\n * PrestaShop is an International Registered Trademark & Property of PrestaShop SA\n *\n * NOTICE OF LICENSE\n *\n * This source file is subject to the Academic Free License 3.0 (AFL-3.0)\n * that is bundled with this package in the file LICENSE.md.\n * It is also available through the world-wide-web at this URL:\n * https://opensource.org/licenses/AFL-3.0\n * If you did not receive a copy of the license and are unable to\n * obtain it through the world-wide-web, please send an email\n * to license@prestashop.com so we can send you a copy immediately.\n *\n * @author PrestaShop SA <contact@prestashop.com>\n * @copyright Since 2007 PrestaShop SA and Contributors\n * @license https://opensource.org/licenses/AFL-3.0 Academic Free License 3.0 (AFL-3.0)\n */\n.faceted-overlay {\n left: 0;\n top: 0;\n width: 100%;\n height: 100%;\n position: fixed;\n background-color: rgba(25, 25, 25, 0.5);\n z-index: 100;\n\n .overlay__inner {\n left: 0;\n top: 0;\n width: 100%;\n height: 100%;\n position: absolute;\n }\n\n .overlay__content {\n left: 50%;\n position: absolute;\n top: 50%;\n transform: translate(-50%, -50%);\n }\n\n .spinner {\n width: 75px;\n height: 75px;\n display: inline-block;\n border-width: 2px;\n border-color: rgba(255, 255, 255, 0.05);\n border-top-color: #fff;\n animation: spin 1s infinite linear;\n border-radius: 100%;\n border-style: solid;\n }\n}\n\n@keyframes spin {\n 100% {\n transform: rotate(360deg);\n }\n}\n","/**\n * Copyright since 2007 PrestaShop SA and Contributors\n * PrestaShop is an International Registered Trademark & Property of PrestaShop SA\n *\n * NOTICE OF LICENSE\n *\n * This source file is subject to the Academic Free License 3.0 (AFL-3.0)\n * that is bundled with this package in the file LICENSE.md.\n * It is also available through the world-wide-web at this URL:\n * https://opensource.org/licenses/AFL-3.0\n * If you did not receive a copy of the license and are unable to\n * obtain it through the world-wide-web, please send an email\n * to license@prestashop.com so we can send you a copy immediately.\n *\n * @author PrestaShop SA <contact@prestashop.com>\n * @copyright Since 2007 PrestaShop SA and Contributors\n * @license https://opensource.org/licenses/AFL-3.0 Academic Free License 3.0 (AFL-3.0)\n */\n#search_filters {\n .ui-slider-horizontal {\n .ui-slider-handle {\n margin-left: -1px;\n cursor: pointer;\n }\n }\n .ui-widget-header {\n background: #555;\n }\n .ui-slider {\n .ui-slider-handle {\n top: -.45em;\n width: 0.4em;\n background: #fff;\n border: 1px solid #555;\n }\n }\n .ui-slider-horizontal {\n height: .4em;\n }\n}\n","/**\n * Copyright since 2007 PrestaShop SA and Contributors\n * PrestaShop is an International Registered Trademark & Property of PrestaShop SA\n *\n * NOTICE OF LICENSE\n *\n * This source file is subject to the Academic Free License 3.0 (AFL-3.0)\n * that is bundled with this package in the file LICENSE.md.\n * It is also available through the world-wide-web at this URL:\n * https://opensource.org/licenses/AFL-3.0\n * If you did not receive a copy of the license and are unable to\n * obtain it through the world-wide-web, please send an email\n * to license@prestashop.com so we can send you a copy immediately.\n *\n * @author PrestaShop SA <contact@prestashop.com>\n * @copyright Since 2007 PrestaShop SA and Contributors\n * @license https://opensource.org/licenses/AFL-3.0 Academic Free License 3.0 (AFL-3.0)\n */\n@mixin text-ellipsis() {\n width: calc(100% - 30px);\n overflow: hidden;\n text-overflow: ellipsis;\n white-space: nowrap;\n}\n\n#search_filters {\n .facet {\n .title {\n display: flex;\n .collapse-icons {\n margin-left: auto;\n }\n }\n\n .facet-title {\n @include text-ellipsis();\n }\n\n .facet-label {\n width: 100%;\n text-align: left;\n .custom-checkbox,\n .custom-radio {\n top: -7px;\n margin-right: 0;\n }\n .color {\n margin-left: 0;\n }\n\n a {\n @include text-ellipsis();\n }\n }\n }\n}\n"],"names":[],"sourceRoot":""} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what file modification did trigger this? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matthieu-rolland Just running npm install
and npm run build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Hlavtox
Thanks for your PR, all improvements for the wording are well displayed ✔️
LGTM ✔️ QA ✔️
See attached screen record :
Module.Manager.prestashop811.mp4
Thanks!
Thanks @aniszr! :-) |
Improved checks on edit filter page
Extended cron tasks section
Added explanations to filter options
Added helper to edit filter page
This change is