Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Avif and WebP support for slider images #101

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

buggyzap
Copy link

Questions Answers
Description? I have added 2 new supported image extensions. Avif and WebP.
Type? improvement
BC breaks? no
Deprecations? no
How to test? Try to upload Avif or WebP image.

Hi, I have created this PR to add supports for Avif and WebP extensions in slider images.

ps_imageslider.php Outdated Show resolved Hide resolved
@buggyzap buggyzap requested a review from nicosomb May 2, 2024 08:11
@florine2623 florine2623 self-assigned this Jun 6, 2024
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @buggyzap ,

Thanks for the PR !

The format Avif doesn't work. Format WebP works fine.

Screen.Recording.2024-06-06.at.16.06.15.mov

Could you check ?
Thanks!

@florine2623 florine2623 removed their assignment Jun 6, 2024
@florine2623
Copy link
Contributor

friendly reminder @buggyzap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for review
Development

Successfully merging this pull request may close these issues.

4 participants