Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v9 compatibility layer for doctrine #224

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

M0rgan01
Copy link
Contributor

@M0rgan01 M0rgan01 commented Oct 2, 2023

Questions Answers
Description? Update repository after bump multiple doctrine deps in core, similar to PrestaShop/productcomments#178
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? -
How to test? Test module in v8.1 and v9

config/services.yml Outdated Show resolved Hide resolved
src/Repository/ConsentRepository.php Outdated Show resolved Hide resolved
@M0rgan01 M0rgan01 force-pushed the fix/v9_compatibility_layer branch 3 times, most recently from fd52daa to bd0b7fd Compare October 3, 2023 07:34
@florine2623 florine2623 self-assigned this Oct 4, 2023
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @M0rgan01 ,

Tested on 8.0.x, 8.1.x and develop branch.

On 8.0.x and 8.1.x :

An exception occurred while executing 'SELECT id_module FROM ps_psgdpr_consent consent LEFT JOIN ps_psgdpr_consent_lang consent_lang ON consent.id_gdpr_consent = consent_lang.id_gdpr_consent WHERE consent.id_module = :id_module':

SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ':id_module' at line 1

Screenshot 2023-10-04 at 14 25 43

On develop :

An exception occurred while executing a query: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ':id_module' at line 1

Screenshot 2023-10-04 at 14 26 19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for review
Development

Successfully merging this pull request may close these issues.

5 participants