with s6 2.13.1.0 binaries live in /usr/bin instead of /bin #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this change makes the entrypoint script PATH dependent, but agnostic to the real location of the s6-svcscan binary, so it work both for alpine 3.20 as well as edge / future stable alpine releases see https://gitlab.alpinelinux.org/alpine/aports/-/commit/d348893ddf28edb773ac69df7129b43b767d8418#bc2914fbfe731ad6ff1eb5c019c39433c87bcaf5_22_24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the entrypoint script PATH dependent, but agnostic to the real location of the s6-svcscan binary, so it work both for alpine 3.20 as well as edge / future stable alpine releases. An alternative would be to detect the presence of the binary in /usr/bin and create a symlink to that into /bin.
Example failing nightly build: https://github.com/PrivateBin/docker-nginx-fpm-alpine/actions/runs/11376261631/job/31648434608
Caused by this change: https://gitlab.alpinelinux.org/alpine/aports/-/commit/d348893ddf28edb773ac69df7129b43b767d8418#bc2914fbfe731ad6ff1eb5c019c39433c87bcaf5_22_24