Items Page Update #123
Items Page Update #123
Conversation
|
I'm still doing some manual testing for this, applying it to our own codebase, but I figured it was best to get it out for review before that was completed. |
|
Hi @pevner-p2, I've made some updates in my pull request that might be helpful. Could you please take a look and see if you'd like to use any of these changes? I'm currently using my version, and I would like it to align with the main version for consistency and better integration. Thanks! |
|
@rhymiz and @chdastolfo, I believe this is now ready for prime-time, I've tested it out on our internal stuff to much success, now waiting on your reviews. @JUSTFUN0368, I definitely want to grab your improvements to the queries for column type specific values. However, I'd like to do it in a separate PR, since the lack of cursor and querying functionality is strongly blocking internal updates here, and I suspect is a problem for other users as well. |
|
All column_id's and group_id's have to be a string. In move_item_to_group_query(), update_item_query(), add_file_to_column_query(). I think these are all queries where you would have to change that |
Good catch, PR updated! |
|
@rhymiz and @chdastolfo, I know you're both busy, but if you've got even an estimate of when you'll be available to review this, it would a big help. |
|
Sorry! I can take a look by tomorrow at the latest.
…On Thu, Dec 14, 2023, 2:38 PM Lemuel Boyce ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#123 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACFMZV6US5LEHHEZIIKGFKDYJNISZAVCNFSM6AAAAABAKIOLD2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOBSGU3TONZQGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
The new Monday API limits how much data can come back in an item query, and now recommends using the
items_pagefunctionality instead. See https://developer.monday.com/api-reference/docs/migrating-to-v-2023-10#case-1-queries-that-use-pagination for details. This expands our client to include support for querying and cursors and limits whereitems_pageis used.