Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/create board by workspace #60

Merged
merged 8 commits into from
Oct 29, 2022

Conversation

albcl
Copy link
Contributor

@albcl albcl commented Jun 18, 2022

What changed:

Added create_boards() function and a test for it.
Also, Readme has been updated.

What resolves:

Issue #59: Will allow users to easily create boards optionally specifying a workspace for it.

monday/query_joins.py Outdated Show resolved Hide resolved
chdastolfo
chdastolfo previously approved these changes Jun 29, 2022
@chdastolfo
Copy link
Collaborator

Adding type hints as @rhymiz requested is non-blocking, but would prefer them to be added before merge @albcl. Would prefer to merge both of your PRs at the same time, if possible.

@albcl
Copy link
Contributor Author

albcl commented Oct 18, 2022

Updated with type hints and some custom ones

@albcl albcl marked this pull request as draft October 18, 2022 12:57
@albcl albcl marked this pull request as ready for review October 18, 2022 15:50
@albcl
Copy link
Contributor Author

albcl commented Oct 18, 2022

I think this should be ready to review now 😄

@rhymiz
Copy link
Collaborator

rhymiz commented Oct 23, 2022

Thanks again @albcl, will take a look!

@rhymiz rhymiz merged commit 1f594a4 into ProdPerfect:master Oct 29, 2022
@rhymiz
Copy link
Collaborator

rhymiz commented Dec 1, 2022

@all-contributors please add @albcl for code

@allcontributors
Copy link
Contributor

@rhymiz

I've put up a pull request to add @albcl! 🎉

@rhymiz
Copy link
Collaborator

rhymiz commented Dec 1, 2022

@all-contributors please add @albcl to code

@allcontributors
Copy link
Contributor

@rhymiz

@albcl already contributed before to code

@rhymiz
Copy link
Collaborator

rhymiz commented Dec 1, 2022

@all-contributors please remove @albcl from code

@allcontributors
Copy link
Contributor

@rhymiz

I could not determine your intention.

Basic usage: @all-contributors please add @Someone for code, doc and infra

For other usages see the documentation

albcl added a commit to albcl/monday that referenced this pull request Dec 9, 2022
* Added "create board by workspace id"

* Update readme

* Added missing type hints

* Updated test

* More custom type hints

* Type hints for 'get_boards_query'

* Fixed tests

* Updated Readme and 'fetch_boards' method
@albcl albcl deleted the feature/create_board_by_workspace_id branch September 15, 2023 14:49
@albcl albcl restored the feature/create_board_by_workspace_id branch September 15, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants