Update Dockerfile to using cache layer #534
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
good job |
|
@piggy2303 Thanks your contribution, before approve,you need to fix the DCO issue |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more. |
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: piggy2303 <nguyentuananh23031997@gmail.com>
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.8.0 to 6.9.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v6.8.0...v6.9.0) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: piggy2303 <nguyentuananh23031997@gmail.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.3 to 4.4.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v3.1.3...v4.4.0) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: piggy2303 <nguyentuananh23031997@gmail.com>
Signed-off-by: jimmy <myemail@example.com> Signed-off-by: piggy2303 <nguyentuananh23031997@gmail.com>
piggy2303
force-pushed
the
dockerfile_optimize
branch
3 times, most recently
from
9564ffd to
db78048
Compare
…rfile_optimize
piggy2303
force-pushed
the
dockerfile_optimize
branch
3 times, most recently
from
d01def6 to
8fa0823
Compare
…sers.noreply.github.com> Update Dockerfile Signed-off-by: TuanAnh Nguyen <33578509+piggy2303@users.noreply.github.com>
Bumps ubuntu from 20.04 to 24.04. --- updated-dependencies: - dependency-name: ubuntu dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
|
@piggy2303 Can you rebase your commits ？ |
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.3 to 4.4.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v3.1.3...v4.4.0) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: piggy2303 <nguyentuananh23031997@gmail.com>
Signed-off-by: jimmy <myemail@example.com> Signed-off-by: piggy2303 <nguyentuananh23031997@gmail.com>
…sers.noreply.github.com> Update Dockerfile Signed-off-by: TuanAnh Nguyen <33578509+piggy2303@users.noreply.github.com>
… into dockerfile_optimize
|
@piggy2303 Hey, you need to rebase this pr to single commits |
wawa0210
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
optimize dockerfile so it can take advantage of cache layer to build docker image faster
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: