Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend a membership by completing a contribution #18

Closed
jaapjansma opened this issue Jun 19, 2018 · 5 comments
Closed

Extend a membership by completing a contribution #18

jaapjansma opened this issue Jun 19, 2018 · 5 comments
Labels
Milestone

Comments

@jaapjansma
Copy link
Contributor

I want to extend the membership period as soon as a pending contribution is set to completed.

The use case is:
I have a membership organisation and I collect membership payment with Sepa Direct Debit. When I create the file the contributions are automaticly linked to the membership (see #10). The contributions are immediatly set to completed as we deal with failures manually. Now I want that the membership is extended with the status current as sson as the contribution is set to completed.

Solution:
Provide a checkbox to enable/disable this functionality from the configuration and then whenever a contribution is updated and the status is set to completed we should extend the membership.

jaapjansma added a commit to jaapjansma/org.project60.membership that referenced this issue Jun 19, 2018
@jaapjansma
Copy link
Contributor Author

I have implemented this below a screenshot of the setting screen
screenshot from 2018-06-19 17-35-14

@bjendres
Copy link
Member

@jaapjansma: Sounds/looks great. I'll have a look and merge when I'm back from BRX.

@bjendres bjendres added this to the 0.5 milestone Jun 20, 2018
@jaapjansma
Copy link
Contributor Author

@systopia I am going to add another commit to check whether the contribution is completed before extending the membership.

jaapjansma added a commit to jaapjansma/org.project60.membership that referenced this issue Jun 20, 2018
@jaapjansma
Copy link
Contributor Author

I have updated the PR (#19). It now triggers when a contribution is completed. It will then check if the contribution is linked with a membership and if so (and the setting is enabled) then it will extend the membership end date.
screenshot from 2018-06-20 17-16-38

@bjendres bjendres modified the milestones: 0.5, 0.6 Aug 2, 2018
@bjendres bjendres modified the milestones: 0.6, 0.5 Sep 4, 2018
@bjendres
Copy link
Member

bjendres commented Sep 4, 2018

released with 0.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants