Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only renew membership when membership has a configured status. #27

Closed
jaapjansma opened this issue Oct 30, 2018 · 2 comments
Closed

Only renew membership when membership has a configured status. #27

jaapjansma opened this issue Oct 30, 2018 · 2 comments

Comments

@jaapjansma
Copy link
Contributor

In issue #18 the functionality to renew a membership upon completing a contribution is added. However when a new membership is created with a pending contribution the membership has status pending. As soon as the membership is paid CiviCRM core sets the status of the membership to new. With the functionality in #18 enabled the membership is renewed immediatly.

Proposal is to add a configuration so that renewal only takes places when the membership has a certain status (e.g. Active).

@jaapjansma
Copy link
Contributor Author

After investigating and testing I discovered a CiviCRM core bug. When CiviCRM is not in English then the membership status cron job processes pending memberships to new, even if a contribution is pending.

@jaapjansma
Copy link
Contributor Author

In the master branch of civicrm core it looks like this issue is solved. I expect that with civicrm 5.7.x this issue will be solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant