Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update membership end date when a membership payment is added #19

Merged

Conversation

jaapjansma
Copy link
Contributor

See issue #18

@bjendres
Copy link
Member

bjendres commented Aug 2, 2018

@jaapjansma I'll have a look at this when 0.5 is out, ok? Cheers!

@bjendres bjendres added this to the 0.6 milestone Aug 2, 2018
@jaapjansma
Copy link
Contributor Author

That is fine. Do you have a clue when 0.5 comes out, roughly?

@bjendres
Copy link
Member

bjendres commented Aug 2, 2018

That is fine. Do you have a clue when 0.5 comes out, roughly?

Soon, if @thomst can confirm that it all works fine now...

@jaapjansma
Copy link
Contributor Author

@systopia I have added another commit as CiviCRM seems to have weird behaviour: if you set a pending contribution to completed through the UI the membership gets renewed. If you set a In Progress contribution to completed the membership does not get renewed. And if you set a contribution to completed through the api it does not get renewed either.

@bjendres
Copy link
Member

bjendres commented Aug 3, 2018

@systopia I have added another commit as CiviCRM seems to have weird behaviour...

Yes, that's what #14 is about. Maybe we can have a chat next week to see what our options are...

@jaapjansma
Copy link
Contributor Author

I have added a another popup to replace the date in the status message after completing a membership contribution from within the UI.

@jaapjansma
Copy link
Contributor Author

@systopia a chat next week is fine. I can do everyday except monday morning and thursday afternoon

@bjendres bjendres merged commit 8fda0b4 into Project60:master Aug 16, 2018
@jaapjansma jaapjansma deleted the issue_18_extend_membership_upon_paying branch August 16, 2018 11:11
@jaapjansma
Copy link
Contributor Author

Thanks.

@bjendres
Copy link
Member

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants