Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update search parameters of new data point with values from parsed meta data file before submission to proteobot #98

Closed
viikiid opened this issue Sep 25, 2023 · 7 comments
Assignees
Labels
high priority to be discussed a decision still needs to be made

Comments

@viikiid
Copy link
Contributor

viikiid commented Sep 25, 2023

Currently the values that are submitted to the public repository are those that users entered in the additional parameters input boxes. As soon as the parsing of the metadatafile is done we will need to change that to the parameters parsed from the meta data file

viikiid added a commit that referenced this issue Sep 25, 2023
added a comment for submission
@scaramonche scaramonche self-assigned this Sep 25, 2023
@RobbinBouwmeester
Copy link
Contributor

@viikiid can you confirm this has been resolved?

@scaramonche
Copy link
Contributor

As far as I understood, this has not been resolved yet, since it is waiting for the parsed meta data to be available in the code.

@viikiid
Copy link
Contributor Author

viikiid commented Oct 17, 2023

This is true, it is not resolved, we need to wait for the parsed metadata file for each search engine

@enryH
Copy link
Member

enryH commented Oct 17, 2023

So here metadata refers to the parsed parameters file #101 , e.g. mqpar.xml for MaxQuant.

@scaramonche scaramonche added to be discussed a decision still needs to be made high priority labels Dec 8, 2023
@scaramonche
Copy link
Contributor

scaramonche commented Dec 8, 2023

There is a branch use-metadata-params-for-submission where I started this. I have not finalized it because the next step would need to be a unification of the set of parameters and their names that we want to keep and provide on the website. One version is what we have as additional parameters on the website (as defined in webinterface/dda_quant.json) and the other version is the parameters extracted from the meta file and currently defined in proteobench/params/__init__.py.
If I understood correctly, the ones Henry used (params init file) is what we agreed on, but I was not sure if the plan is to use exactly those for the website as well.

@enryH
Copy link
Member

enryH commented Dec 9, 2023

We agreed to select and use the names aligned with the SDRF-extended parameters. Some parameters which are needed for a task and are not defined by SDRF-extended will need to be added. See #58 for previous discussion, especially the last comment:
#58 (comment)

@RobbinBouwmeester
Copy link
Contributor

Fixed in #158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority to be discussed a decision still needs to be made
Projects
None yet
Development

No branches or pull requests

4 participants