docs: Remove redundant example code #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twiss
reviewed
Sep 9, 2024
There was a problem hiding this comment.
Hey 👋 Good catch! However, probably it would make more sense to just remove this example for now (since it's pretty useless as-is), until we can make it true and generate v4 Curve448 keys. RFC9580 (which introduces Curve448) is out now, but we might still want to wait a bit for support to become more widespread.
pascal-hofmann
force-pushed
the
patch-1
branch
2 times, most recently
from
aa40c6c
to
91f578d
Compare
pascal-hofmann
changed the title
The code also generates curve25519 v4 keys at the moment.
pascal-hofmann
force-pushed
the
patch-1
branch
from
91f578d
to
4226c6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code also generates curve25519 v4 keys at the moment.