Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a few questions #1

Open
fenugrec opened this issue Jun 27, 2022 · 0 comments
Open

a few questions #1

fenugrec opened this issue Jun 27, 2022 · 0 comments

Comments

@fenugrec
Copy link

Hi,
cool project, thanks for sharing. I'm quickly looking over the code, and have a few questions :

  • have you considered putting in libdfloat as a git submodule ? allows you to ensure a "known working" libdfloat commit is used, and spares the user from cloning two different trees
  • you sure went to town with the state machines all over the place ! : ) Any particular reason to do this for the core CSV parsing rather than e.g. an ANTLR grammar and parser ? seems like CSV would lend itself well to that. Or even just libcsv as the low-level backend.
  • any plans to keep working on this or would you consider it dormant ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fenugrec