Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ap phs pub linkage #2

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Ap phs pub linkage #2

wants to merge 5 commits into from

Conversation

abigap01
Copy link

Hi Monica,

Another update to a shiny app for the ScotPHO website. I have revived this one which used an old Health Protection publication which PHS picked up post-covid. Hopefully everything looks good on the data prep side of things too as this needed reworking a bit to account for missing data years etc.

Thanks,
Abbie

Copy link

@monicamcgibbon monicamcgibbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @abigap0. I've just made a few changes. Firstly, the data for the shiny app needs to be saved within the repository itself. It works fine when pointing to data saved on the network when you're running the app locally but it wouldn't work if it was deployed because it wouldn't know how to access those filepaths. When you deploy the app you also need to include the data that's required for it too. The data prep code also needs to be commented out for deploying for the same reasons. Also, nothing to do with you but the code was a little confusing to follow so I've re-organised it and adding some analyst notes at the top for the next person - can you please add to/amend the notes to make it easier for whoever needs to update next year? Let me know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants