Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.10.0 #55

Merged
merged 58 commits into from
Jul 24, 2023
Merged

v0.10.0 #55

merged 58 commits into from
Jul 24, 2023

Conversation

Moohan
Copy link
Member

@Moohan Moohan commented Jun 21, 2023

No description provided.

Moohan and others added 30 commits February 17, 2023 12:52
* Improve chi and anon_chi

This update requires the `{openssl}` package but is hugely faster and more memory efficient than reading the lookup every time.

* Style with {styler} (GitHub action)

* Remove old code left from testing

* Style with {styler} (GitHub action)

* run `test-get_anon_chi.R` on CI

Since these tests are no longer dependent on a local file, they can be ran on our CI pipeline.

* Add tests for `get_chi` that can be run on CI

---------

Co-authored-by: Moohan <Moohan@users.noreply.github.com>
Also, make the documentation slightly nicer.
* Make the check on the CHIs optional

* Style with {styler} (GitHub action)

* Update documentation (GitHub action)

* Update get_anon_chi.R

* Style with {styler} (GitHub action)

* Update R/get_anon_chi.R

---------

Co-authored-by: Moohan <Moohan@users.noreply.github.com>
…chi` (#58)

* Make `anon_chi` appear in the same place as `chi`

* Style with {styler} (GitHub action)

* Update get_anon_chi.R

* Update get_chi.R

* Style with {styler} (GitHub action)

* Update get_chi.R

---------

Co-authored-by: Moohan <Moohan@users.noreply.github.com>
Moohan and others added 25 commits July 24, 2023 17:49
Co-authored-by: Jennit07 <67372904+Jennit07@users.noreply.github.com>
`get_chi()` and `get_anon_chi()` now properly match missing (`NA`) and blank (`""`) values.
* Make 1112 the min year

I noticed that min_year was 1213 but this isn't correct.

Tests might also need updating...

* Update tests

* Update documentation (GitHub action)

---------

Co-authored-by: Moohan <Moohan@users.noreply.github.com>
@Moohan Moohan marked this pull request as ready for review July 24, 2023 17:41
@Moohan Moohan self-assigned this Jul 24, 2023
@Moohan Moohan enabled auto-merge July 24, 2023 18:34
@Moohan Moohan disabled auto-merge July 24, 2023 18:34
@Moohan Moohan merged commit 28b2418 into production Jul 24, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants