-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.10.0 #55
Merged
Merged
v0.10.0 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve chi and anon_chi This update requires the `{openssl}` package but is hugely faster and more memory efficient than reading the lookup every time. * Style with {styler} (GitHub action) * Remove old code left from testing * Style with {styler} (GitHub action) * run `test-get_anon_chi.R` on CI Since these tests are no longer dependent on a local file, they can be ran on our CI pipeline. * Add tests for `get_chi` that can be run on CI --------- Co-authored-by: Moohan <Moohan@users.noreply.github.com>
Also, make the documentation slightly nicer.
Implement `check_year`
* Make the check on the CHIs optional * Style with {styler} (GitHub action) * Update documentation (GitHub action) * Update get_anon_chi.R * Style with {styler} (GitHub action) * Update R/get_anon_chi.R --------- Co-authored-by: Moohan <Moohan@users.noreply.github.com>
…chi` (#58) * Make `anon_chi` appear in the same place as `chi` * Style with {styler} (GitHub action) * Update get_anon_chi.R * Update get_chi.R * Style with {styler} (GitHub action) * Update get_chi.R --------- Co-authored-by: Moohan <Moohan@users.noreply.github.com>
…ug with filtering on partnership
Co-authored-by: Jennit07 <67372904+Jennit07@users.noreply.github.com>
`get_chi()` and `get_anon_chi()` now properly match missing (`NA`) and blank (`""`) values.
Using the latest examples from https://github.com/r-lib/actions/tree/v2/examples
* Make 1112 the min year I noticed that min_year was 1213 but this isn't correct. Tests might also need updating... * Update tests * Update documentation (GitHub action) --------- Co-authored-by: Moohan <Moohan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.