Add multi noise biome source #445
Open
+169
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kralverde
reviewed
Jan 2, 2025
| } | ||
|
|
||
| pub struct MultiNoiseSampler { | ||
| pub(crate) temperature: Box<dyn ComponentReference<NoEnvironment>>, |
There was a problem hiding this comment.
This can be a shared or mutable component reference depending on what is needed, if no environment is needed, they can probably be SharedComponentReference and then you can call sample instead of sample_mut
Snowiiii
reviewed
Jan 2, 2025
| @@ -59,3 +59,4 @@ uuid = { version = "1.11.0", features = ["serde", "v3", "v4"] } | |||
| derive_more = { version = "1.0.0", features = ["full"] } | |||
| serde = { version = "1.0", features = ["derive"] } | |||
| serde_json = "1.0" | |||
| serde_with = "3.12" | |||
There was a problem hiding this comment.
Why this was added ?, And is there a way to get the same done without this ?
There was a problem hiding this comment.
it was added to serialize {"key":value} as Vec<(Key,Value)>, i can change the format of the data in extractor to be an array
There was a problem hiding this comment.
Having a library less seems better
|
@urisinger any progress on this one ? |
I've been busy the past few days, I'll pick it up next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this pr adds MultiNoiseBiomeSource and BiomeEntries to generate biomes, which is supposed to mimic MultiNoiseUtil and MultiNoiseBiomeSource.
Testing
not yet
Please follow our Coding Guidelines