Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/add cache #28

Merged
merged 3 commits into from
Mar 9, 2021
Merged

Dev/add cache #28

merged 3 commits into from
Mar 9, 2021

Conversation

joequant
Copy link

@joequant joequant commented Oct 7, 2020

This patch helps with jpmorganchase/jupyter-fs#58

Without caching jupyter-fs will try to pull the information from webdav with a lot of calls rendering it unusable. With caching jupyter-fs is slow but usable.

@abretaud
Copy link
Contributor

abretaud commented Mar 9, 2021

Looks exciting but looks like there's a conflict included in the diff

@zopyx zopyx merged commit 4139d39 into PyFilesystem:master Mar 9, 2021
@zopyx
Copy link
Contributor

zopyx commented Mar 9, 2021

Merged and releaded with 0.4.0.
Thanks for your contribution!

@abretaud
Copy link
Contributor

abretaud commented Mar 9, 2021

Cool that was fast :)
For this one have you seen that there was some conflict left in the code? https://github.com/PyFilesystem/webdavfs/pull/28/files#diff-419f6744efd46a5bf1d476b1706a3fb410405ec3d2413c7025180c2405ab6239R239

@zopyx zopyx mentioned this pull request Mar 9, 2021
@zopyx
Copy link
Contributor

zopyx commented Mar 9, 2021

@joequant I had to revert the merge. Can you please submit an updated version of the PR in order to merge it properly into 0.4?

@ghost
Copy link

ghost commented Mar 9, 2021

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

abretaud added a commit to abretaud/webdavfs that referenced this pull request Mar 10, 2021
zopyx added a commit that referenced this pull request Mar 10, 2021
Readd caching (based on #28)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants