Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade maturin #9

Merged
merged 6 commits into from
Dec 7, 2024
Merged

Upgrade maturin #9

merged 6 commits into from
Dec 7, 2024

Conversation

mbway
Copy link
Collaborator

@mbway mbway commented Nov 17, 2024

upgrade to latest packages.

(draft: waiting on #8 )

@mbway mbway requested a review from messense November 17, 2024 16:45
@mbway mbway force-pushed the upgrade_maturin branch 3 times, most recently from 93bd51a to 0873398 Compare November 17, 2024 19:10
@mbway mbway self-assigned this Nov 17, 2024
@mbway mbway removed the request for review from messense November 17, 2024 19:44
@mbway
Copy link
Collaborator Author

mbway commented Nov 17, 2024

currently maturin new --bindings creates projects using pyo3 == 0.22.0 which is why the tests are failing because I upgraded the projects to be 0.23.1. PyO3/maturin#2308 is merged and changes to use 0.23.1 but I think this PR should wait until the next maturin release so the import hook is tied to a release tag of maturin and not a random commit

@mbway mbway mentioned this pull request Nov 30, 2024
2 tasks
@mbway
Copy link
Collaborator Author

mbway commented Nov 30, 2024

need to wait for PyO3/maturin#2347 and PyO3/maturin#2346 to fix the remaining test failures.

@mbway
Copy link
Collaborator Author

mbway commented Dec 1, 2024

tests now pass locally. Waiting for the next maturin release to pin to

@mbway mbway marked this pull request as ready for review December 6, 2024 21:26
@mbway mbway mentioned this pull request Dec 6, 2024
@mbway mbway requested a review from messense December 6, 2024 23:43
@messense messense merged commit dddccd1 into PyO3:main Dec 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants